Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate copies of Google fonts in the repo #6832

Closed
fmarier opened this issue Nov 7, 2019 · 5 comments · Fixed by brave/brave-core#4004
Closed

Duplicate copies of Google fonts in the repo #6832

fmarier opened this issue Nov 7, 2019 · 5 comments · Fixed by brave/brave-core#4004

Comments

@fmarier
Copy link
Member

fmarier commented Nov 7, 2019

We have two copies of the Muli and Poppins fonts in brave-core:

Presumably one of these could refer to the other one.

@fmarier
Copy link
Member Author

fmarier commented Nov 13, 2019

This causes Muli to appear twice in brave://credits (#6881).

@fmarier
Copy link
Member Author

fmarier commented Nov 16, 2019

The two muli.css files aren't identical but from what I can see the only difference is that the one in ui/webui defines more sizes.

Same with the poppins.css files.

@btlechowski
Copy link

@fmarier It seems that test plan from brave/brave-core#4004 requires dev environment. Is there a way to test without it?

#6881 has already been verified. Maybe it is enough?

@fmarier
Copy link
Member Author

fmarier commented Jan 6, 2020

It seems that test plan from brave/brave-core#4004 requires dev environment. Is there a way to test without it?

The alternative is to look at the various pages (listed in the PR) where we use the fonts and check that they "look right". I thought I wouldn't necessarily notice if the fonts had changed which is why I hacked the colors in my test.

Maybe someone with a good eye for fonts can double-check that everything looks right in Beta?

@btlechowski
Copy link

btlechowski commented Jan 9, 2020

I tried to see but I am blind!

Verified to the best of my ability (#6832 (comment))

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

I used dev tools to check fonts from the list from brave/brave-core#4004
Also checked brave://resources

image
image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
  • ensured that the pages listed under Remove duplicate fonts brave-core#4004 rendered and looked correct
  • ensured that brave://brave-resources/fonts/muli.css & brave://brave-resources/fonts/poppins.css wasn't broken

Screen Shot 2020-01-15 at 12 23 12 PM

Screen Shot 2020-01-15 at 12 23 04 PM

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that the pages listed under Remove duplicate fonts brave-core#4004 rendered and looked correct
  • ensured that brave://brave-resources/fonts/muli.css & brave://brave-resources/fonts/poppins.css wasn't broken
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants