Global Shields toggle for cookies does not work

[jumde]

Steps to Reproduce

1. Toggle global shield settings to block all cookies
2. Navigate to https://www.whatismybrowser.com/detect/are-third-party-cookies-enabled
3. You should see No
4. Re-toggle the global shield settings to block-only-cross-site setting
5. Navigate to https://www.whatismybrowser.com/detect/are-third-party-cookies-enabled

Test Plan:

Specified here - brave/brave-core#3903

Actual result:

Third party cookies are not blocked

Expected result:

Third party cookies should be blocked

Reproduces how often:

Easily

Brave version (brave://version info)

0.73.60 Chromium: 78.0.3904.87 (Official Build) nightly (64-bit) - Nightly
0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit) - Release

[bridiver]

I can't replicate this in 0.70.122

[jumde]

Transition from Block all -> Block 3rd parties does not work

[bridiver]

I was able to replicate that specific transition so it does depend on the exact sequence and other transitions work correctly.

[btlechowski]

Verification passed on

Brave	1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3903

Only block only cross-site cookies

Allow all cookies

Verified passed with

Brave	1.3.88 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.14.6 (Build 18G103)

• Reproduced the issue using 1.2.42 Chromium: 79.0.3945.117
• Verified test plan from Fix 6804: Avoid the OnPreferenceChanged callback when preferences are changed by CookiePrefService brave-core#3903
• Verified STR from description

3rd party cookies blocked:

all cookies blocked:

all cookies allowed:

Verification passed on

Brave	1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Fix 6804: Avoid the OnPreferenceChanged callback when preferences are changed by CookiePrefService brave-core#3903
• Verified the STR from the description
  Block all cookies

block only cross-site cookies

Allow all cookies