Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP BR widget needs to be BAT points compatible #6598

Closed
mandar-brave opened this issue Oct 24, 2019 · 1 comment · Fixed by brave/brave-core#3624
Closed

NTP BR widget needs to be BAT points compatible #6598

mandar-brave opened this issue Oct 24, 2019 · 1 comment · Fixed by brave/brave-core#3624
Assignees
@ryanml
Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.0.0 - Release

Comments

@mandar-brave
Copy link

For locales where BAT Points are to be needed, the NTP widget needs to support BAT Points where applicable.

cc @mattmcalister @NejcZdovc
@mandar-brave mandar-brave changed the title NTP widget needs to be BAT points compatible NTP BR widget needs to be BAT points compatible Oct 24, 2019
@NejcZdovc NejcZdovc added this to the 0.71.x - Beta milestone Oct 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 25, 2019
@ryanml
Checking onlyAnonWallet for currency display
51b34db 
Fixes brave/brave-browser#6598
@ryanml ryanml mentioned this issue Oct 30, 2019
Merged
32 tasks
ryanml added a commit to brave/brave-core that referenced this issue Oct 31, 2019
@ryanml
Feature brave/brave-browser#6370 - Adding Rewards widget to NTP
a54ee96 
Checking onlyAnonWallet for currency display

Fixes brave/brave-browser#6598
@ryanml ryanml mentioned this issue Nov 1, 2019
Merged
@ryanml ryanml mentioned this issue Nov 1, 2019
Merged
This was referenced Nov 6, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Nov 11, 2019 •
edited by btlechowski
Loading

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Screen Shot 2019-11-11 at 3 29 11 PM

Screen Shot 2019-11-11 at 3 31 40 PM

Screen Shot 2019-11-11 at 3 36 54 PM

Screen Shot 2019-11-11 at 3 14 15 PM

Screen Shot 2019-11-11 at 3 22 05 PM

Screen Shot 2019-11-11 at 3 19 31 PM

Screenshot 2019-11-11 at 17 01 44

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1903 (Build 18362.388)

  • NTP BR widget on clean profile before rewards is enabled
    image

  • NTP BR widget
    image

  • NTP BR widget when rewards is off
    image

  • NTP BR widget with ads off
    image

  • NTP BR widget with UGP grant message
    image

  • NTP BR widget with Ads grant message
    image

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Adding Rewards Widget for New Tab Page brave/brave-core
7 participants
@kjozwiak @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski @mandar-brave