Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save state logs uses MetaMask in download file name #6281

Closed
srirambv opened this issue Oct 2, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#80
Closed

Save state logs uses MetaMask in download file name #6281

srirambv opened this issue Oct 2, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#80

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2019

Description

Save state logs uses MetaMask in download file name

Steps to Reproduce

  1. Create a crypto wallet and do some transaction
  2. Open Settings -> Advanced -> Download State Logs
  3. Download file name contains Metamask

Actual result:

image

Expected result:

Should have Brave branding

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Oct 8, 2019

@bbondy should we move this into https://github.com/brave/brave-browser/milestone/55 as we're going to need a new build for #5698 and possibly #5106?

@bbondy bbondy added this to the Ethereum Remote Client 1.0.10 milestone Oct 8, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 9, 2019

Verification PASSED on macOS 10.14.6 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15 via the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that downloading the State Log is being saved as Brave State Logs.json on both new wallets and restored wallets.

Screen Shot 2019-10-09 at 12 24 28 AM

Verification PASSED on Windows 10 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15 via the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1809 (Build 17763.737)
  • ensured that downloading the State Log is being saved as Brave State Logs.json on both new wallets and restored wallets.

Annotation 2019-10-09 005005

@srirambv
Copy link
Contributor Author

srirambv commented Oct 9, 2019

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified on 0.1.16 component
  • Verified on both new wallet and restored wallet
    image

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants