Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode for ethereum-remote-client extension pages #5106

Closed
bbondy opened this issue Jul 3, 2019 · 8 comments
Closed

Add dark mode for ethereum-remote-client extension pages #5106

bbondy opened this issue Jul 3, 2019 · 8 comments
Assignees
@ryanml
Labels
feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Milestone
Closed / Dupe / I...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 3, 2019

Other pages in the header when in dark mode will be dark mode, so we need it for this as well.
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 3, 2019
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Aug 14, 2019
@ryanml ryanml mentioned this issue Aug 21, 2019
Merged
@bbondy
Copy link
Member Author

bbondy commented Aug 23, 2019

Closed with brave/ethereum-remote-client#59

@bbondy bbondy closed this as completed Aug 23, 2019
@bbondy bbondy reopened this Oct 2, 2019
@bbondy
Copy link
Member Author

bbondy commented Oct 2, 2019

Reverted here due to screenshots here:
brave/ethereum-remote-client#75

Please re-land once that's fixed. Thanks!

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Oct 2, 2019
@bbondy bbondy closed this as completed Oct 7, 2019
@bbondy bbondy added this to the Ethereum Remote Client 1.0.10 milestone Oct 7, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019 •
edited
Loading

@ryanml looks like dark themes are not working when using https://github.com/brave/ethereum-remote-client/releases/tag/1.0.10. Could this because we're side loading the extension and it's not picking up the themes? It doesn't matter if you you try using dark theme via Same as macOS or switching it to dark within brave://settings, you'll always get the following:

Screen Shot 2019-10-07 at 7 19 41 PM

Screen Shot 2019-10-07 at 7 20 30 PM

@ryanbr
Copy link

ryanbr commented Oct 8, 2019

@kjozwiak probably not my request :)

@kjozwiak
Copy link
Member

kjozwiak commented Oct 8, 2019 •
edited
Loading

@kjozwiak probably not my request :)

Apologies :) Started typing "Rya" and tabbed but looks like the wrong name was selected from the GH username dropdown!

This was referenced Oct 8, 2019
Closed
Closed
@ryanml ryanml mentioned this issue Oct 9, 2019
Merged
@bbondy
Copy link
Member Author

bbondy commented Oct 9, 2019

re-opening because reverted

@bbondy bbondy reopened this Oct 9, 2019
@bbondy bbondy mentioned this issue Oct 9, 2019
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Oct 9, 2019

@srirambv created #6381 which shows several of the theming issues when using dark mode.

@kjozwiak kjozwiak removed this from the Ethereum Remote Client 1.1.15 milestone Oct 9, 2019
@bbondy
Copy link
Member Author

bbondy commented Dec 20, 2019

Closing this in favor of #6381

@bbondy bbondy closed this as completed Dec 20, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
5 participants
@bbondy @ryanbr @kjozwiak @ryanml @srirambv