Crypto Wallets setting: text & functionality

[tildelowengrimm]

The switch to enable/disable Crypto Wallets in settings currently reads "Brave Wallet", but it should be "Crypto Wallets".

When the toggle is unchecked (disabled), the Crypto Wallets item continues to show up in the header, but is hidden in the hamburger menu. But clicking on the header item leads to a broken page.

Instead, the header item should be hidden, while the hamburger menu item is greyed out.

[bbondy]

I believe the header item is tracked separately and @ryanml knows about it. Using this issue to correct the text though.

[GeetaSarvadnya]

@bbondy As per the PR https://github.com/brave/brave-core/pull/3587/files - text change from Brave Wallet to Crypto Wallets is fixed. When the Crypto Wallets toggle is unchecked (disabled) in settings, the Crypto Wallets menu item is hidden from the hamburger menu should it be greyed out? As per the description #6172 (comment) it should be greyed out.

Will it be covered/fixed in the issue #6393? If so, this needs to be mentioned in the issue.

[bbondy]

I'm ok with hidden

[GeetaSarvadnya]

Verification passed on

Brave	1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the description mentioned in the issue
• Verified that Brave Wallet is renamed to Crypto Wallets under chrome://settings/extensions
• Verified that the Crypto Wallets menu item is hidden from the hamburger menu when crypto wallets toggle is unchecked (disabled) in settings
• Verified that header item Crypto Wallets is still not hidden or removed when crypto wallets toggle is unchecked (disabled) in settings - This will be fixed/addressed in the issue Hide Crypto Wallets top nav item when feature is disabled #6393 as per the Crypto Wallets setting: text & functionality #6172 (comment)

Verification passed on

Brave	1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

• Verified the test plan from the description
• Verified that Brave Wallet is renamed to Crypto Wallets under chrome://settings/extensions
• Verified that the Crypto Wallets menu item is hidden from the hamburger menu when crypto wallets toggle is unchecked (disabled) in settings
• Verified that header item Crypto Wallets is still not hidden or removed when crypto wallets toggle is unchecked (disabled) in settings - This will be fixed/addressed in the issue Hide Crypto Wallets top nav item when feature is disabled #6393 as per the Crypto Wallets setting: text & functionality #6172 (comment)
• Encountered brave://wallet should always open in normal window #6637 while testing

Verified passed with

Brave	1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified the description mentioned in the issue
• Verified that Brave Wallet is renamed to Crypto Wallets under chrome://settings/extensions

• Verified that the Crypto Wallets menu item is hidden from the hamburger menu when crypto wallets toggle is unchecked (disabled) in settings
• Verified that header item Crypto Wallets is still not hidden or removed when crypto wallets toggle is unchecked (disabled) in settings - This will be fixed/addressed in the issue Hide Crypto Wallets top nav item when feature is disabled #6393 as per the Crypto Wallets setting: text & functionality #6172 (comment)