-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to disable the Scripts blocked
after upgrade to 0.68.133
#5973
Comments
Reproduced on Ubuntu. Steps used:
|
Reproduced on macOS using STR from description when updating from
Note - close and restart of Brave did not resolve this. Additionally, could not reproduce when updating from |
Scripts blocked
after upgrade to 0.68.33Scripts blocked
after upgrade to 0.68.133
Found a scenario that occurs on a clean profile with 0.68.133:
|
Confirmed this is a regression |
Also confirmed this is a bug in Nightly Here's what's happening in the code (using use-case from Laurens post above)
(in
|
I believe I found the cause: Here's what my content settings look like after making this change (from {
"profile": {
"content_settings": {
"exceptions": {
"javascript": {
"https://brianbondy.com,*": {
"last_modified": "13212630641208984",
"setting": 2
},
"https://brianbondy.com:443,*": {
"last_modified": "13212622765957903",
"setting": 1
}
}
}
}
}
} The top version (has setting 2) is what I set (block). The bottom one is what I did using the Chromium UI (allow). Only difference is the port is attached to the key |
This fixes a regression unintentionally introduced with #3033 where port would not added (but chromium would add port when you block/unblock using omnibox) Fixes brave/brave-browser#5973
This fixes a regression unintentionally introduced with #3033 where port would not added (but chromium would add port when you block/unblock using omnibox) Fixes brave/brave-browser#5973
Fixed in 0.68.x with brave/brave-core@70b326b Still an issue in 0.69/0.70/0.71/0.72 |
Closing as this issue is fixed in 0.68.x (there are some failing browser tests - those are being fixed right now) |
Verification passed on
Verification passed on
Verification PASSED on
|
Description
Unable to disable the
Scripts blocked
after upgrade to 0.68.33Steps to Reproduce
Scripts blocked
switch after upgradeScripts blocked
after upgrade to 0.68.33Actual result:
Expected result:
Should be able to disable the
Scripts blocked
after upgrade to 0.68.33Reproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@brave/legacy_qa
The text was updated successfully, but these errors were encountered: