Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDFium shows Brave Software Drive in save as pdf modal #5450

Closed
srirambv opened this issue Jul 30, 2019 · 6 comments · Fixed by #8012 or brave/brave-core#4475
Closed

PDFium shows Brave Software Drive in save as pdf modal #5450

srirambv opened this issue Jul 30, 2019 · 6 comments · Fixed by #8012 or brave/brave-core#4475
Assignees
@simonhong
Labels
branding bug priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/include
Milestone
1.5.x - Release

Comments

@srirambv
Copy link
Contributor

Description

PDFium shows Brave Software Drive in save as pdf modal

Steps to Reproduce

  1. Install beta
  2. Open any page and try to print
  3. On the save file dropdown, shows Save to Brave Software Drive which is not a valid option

Actual result:

Screenshot from 2019-07-30 10-51-40

Expected result:

Screenshot from 2019-07-30 10-51-21

Reproduces how often:

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @simonhong @bsclifton
@rebron added P3 so that it can ride the trains. Please change the priority if you think it's required
@kjozwiak
Copy link
Member

Reproduced on macOS 10.14.5 x64 using the following build:

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Example on macOS:

Screen Shot 2019-07-30 at 11 54 55 AM

@LaurenWags
Copy link
Member

Reproduces on 0.67.125 also:

Brave 0.67.125 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Screen Shot 2019-08-15 at 5 19 31 PM

@srirambv
Copy link
Contributor Author

+1 from community https://community.brave.com/t/what-is-save-to-brave-software-drive/83298/3

@ivanhercaz
Copy link

ivanhercaz commented Nov 25, 2019 •
edited
Loading

Reproduced on Brave 1.0.1 with Debian 10.

Brave 1.0.1 Chromium: 78.0.3904.108 (Build oficial) (64 bits)
Revisión 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux (Debian 10)

brave_software_drive

@Jacalz
Copy link
Contributor

Jacalz commented Jan 10, 2020

I can reproduce this too on the latest version 1.2.42 on Windows 10.

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
OS Windows 10

@simonhong simonhong self-assigned this Feb 2, 2020
@simonhong simonhong added this to the 1.5.x - Nightly milestone Feb 2, 2020
simonhong added a commit that referenced this issue Feb 2, 2020
@simonhong
Fixup some strings for google product names
d1cd6a6 
We should not replace google's own product name such as Google Docs
or Google Drive.

fix #5450
simonhong added a commit to brave/brave-core that referenced this issue Feb 2, 2020
@simonhong
Fixup some strings for google product names
cfae9de 
We should not replace google's own product name such as Google Docs
or Google Drive.

fix brave/brave-browser#5450
This was referenced Feb 2, 2020
Merged
Merged
simonhong added a commit that referenced this issue Feb 3, 2020
@simonhong
Fixup some strings for google product names
d748a44 
We should not replace google's own product name such as Google Docs
or Google Drive.

fix #5450
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 27, 2020 •
edited by btlechowski
Loading

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    image
    image

Verified passed with

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-02-27 at 4 24 52 PM

Verification passed on

Brave 1.5.101 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image

@kjozwiak kjozwiak mentioned this issue Mar 17, 2020
Closed
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@simonhong
Fixup some strings for google product names
1d0e89e 
We should not replace google's own product name such as Google Docs
or Google Drive.

fix brave/brave-browser#5450
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@simonhong
Fixup some strings for google product names
78ec25a 
We should not replace google's own product name such as Google Docs
or Google Drive.

fix brave/brave-browser#5450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
branding bug priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.5.x - Release
9 participants
@kjozwiak @bsclifton @simonhong @ivanhercaz @srirambv @Jacalz @LaurenWags @btlechowski @GeetaSarvadnya