Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields should provide a way to persist state across tabs #4953

Closed
cezaraugusto opened this issue Jun 17, 2019 · 0 comments · Fixed by brave/brave-core#2874
Closed

Shields should provide a way to persist state across tabs #4953

cezaraugusto opened this issue Jun 17, 2019 · 0 comments · Fixed by brave/brave-core#2874
Assignees
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. QA/No release-notes/exclude

Comments

@cezaraugusto
Copy link
Contributor

Persistent state only happens in the C++ back-end. Shields should provide a storage mechanism to handle persistent/non-critical state such as on-boarding, simple/advanced views, high-level user preferences, and shared state.

@cezaraugusto cezaraugusto added the feature/shields/panel Front-end design and functionality of the Shields panel. label Jun 17, 2019
@cezaraugusto cezaraugusto self-assigned this Jun 17, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 5, 2019
close brave/brave-browser#4953

Shields state needed across windows/tabs is not stored in localStorage API.
This follows the webUI convention for persistent state.

Goal is to provide a way to handle upcoming changes such as onboarding screen
and simple/advanced view setting.

Other state such as stats, resources blocked, and blocking preferences are still
handled by the back-end and are left untouched.
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 9, 2019
close brave/brave-browser#4953

Shields state needed across windows/tabs is not stored in localStorage API.
This follows the webUI convention for persistent state.

Goal is to provide a way to handle upcoming changes such as onboarding screen
and simple/advanced view setting.

Other state such as stats, resources blocked, and blocking preferences are still
handled by the back-end and are left untouched.
@cezaraugusto cezaraugusto added this to the 0.69.x - Nightly milestone Jul 10, 2019
tmancey pushed a commit that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants