We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to disable content-level tips.
Unable to uncheck Twitter.
Able to uncheck Twitter.
easily
cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim
The text was updated successfully, but these errors were encountered:
@NejcZdovc I think the problem is in the ON_INLINE_TIP_SETTINGS_CHANGE reducer, where it makes this check:
ON_INLINE_TIP_SETTINGS_CHANGE
if (!value || value === '') { break }
Seems like that will prevent a false value from ever being allowed...
Sorry, something went wrong.
Fixes setting twitter inline tip setting
255f073
Resolves brave/brave-browser#4559
Verified passed with
Verification passed on
Twitter
NejcZdovc
Successfully merging a pull request may close this issue.
Description
Unable to disable content-level tips.
Steps to Reproduce
Actual result:
Unable to uncheck Twitter.
Expected result:
Able to uncheck Twitter.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim
The text was updated successfully, but these errors were encountered: