On Twitter is repeated twice on BR panel

[srirambv]

Description

On Twitter is repeated twice on BR panel

Steps to Reproduce

1. Enable rewards on 0.67.51
2. Upgrade to 0.67.55
3. Visit a verified Twitter publisher
4. on Twitter is repeated twice in the panel

Actual result:

Expected result:

Should not duplicate the platform name on the panel

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.67.55 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the dev channel? N/A
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @NejcZdovc

[LaurenWags]

On a clean profile, the @ handle is in parenthesis, but no double 'on Twitter' observed:

Brave	0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS	Mac OS X

[NejcZdovc]

I can't reproduce this one the latest nightly Version 0.67.62 Chromium: 75.0.3770.38 (Official Build) nightly (64-bit)

[NejcZdovc]

@srirambv @LaurenWags can you please try again on a clean profile?

[srirambv]

I can reproduce on a clean profile of last nightly

Brave	0.67.62 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}

Two different behaviour on different profiles. Also notice how the image is shrinked when Twitter handle is included with the publisher name

[NejcZdovc]

@srirambv which OS is this? I am trying to find what is the difference

[srirambv]

@NejcZdovc

[LaurenWags]

@NejcZdovc my comment above reproduces on a clean profile with

Brave	0.67.62 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS	Mac OS X

[LaurenWags]

Had a call with @NejcZdovc to discuss this one - he noticed that if handle starts with a capital letter, we're not parsing correctly. Here are some examples:
https://twitter.com/kamiljozwiak

https://twitter.com/bravesampson

And when the handle starts with lower case letter:
https://twitter.com/bvsriram

https://twitter.com/emerick

https://twitter.com/bravelaurenwags

[LaurenWags]

Verified passed with

Brave	0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

• Verified test plan from Fixes duplicated name in the name brave-core#2516
• Visited twitter pages listed in On Twitter is repeated twice on BR panel #4554 (comment) and they displayed as expected
  
  

Verification passed on

Brave	0.67.106 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• Verified test plan from Fixes duplicated name in the name brave-core#2516
• Visited twitter pages listed in On Twitter is repeated twice on BR panel #4554 (comment) and they displayed as expected

Verification passed on

Brave	0.67.110 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Linux

• Verified test plan from Fixes duplicated name in the name brave-core#2516
• Visited twitter pages listed in On Twitter is repeated twice on BR panel #4554 (comment) and they displayed as expected