Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word count may be incorrect when setting up sync #43635

Closed
3 of 6 tasks
fuchenshi opened this issue Jan 31, 2025 · 3 comments · Fixed by brave/brave-core#27450
Closed
3 of 6 tasks

Word count may be incorrect when setting up sync #43635

fuchenshi opened this issue Jan 31, 2025 · 3 comments · Fixed by brave/brave-core#27450

Comments

@fuchenshi
Copy link

Description

I've found 2 problems related to word counts in the Sync Setup feature:

  1. When a user views a generated sync chain code, the word count displayed below the code is always 0. The user may expect to see the actual word count here because when they enter the code on another device, they may want to compare the word counts to confirm that they have entered the correct number of words.
  2. When a user enters a sync chain code, if the user types something and then clears the input field, the word count will not reset to 0.

Steps to reproduce

For problem 1:

  1. Go to Settings > Sync > Start using sync > Start a new Sync Chain > Computer.

For problem 2:

  1. Go to Settings > Sync > Start using sync > I have a Sync Code.
  2. Type something, then delete everything.

Actual result

For problem 1, the word count displayed is 0.

For problem 2, the word count is not reset to 0.

Expected result

For problem 1, the word count should be the number of words shown above.

For problem 2, the word count should be 0.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.74.51 Chromium: 132.0.6834.160 (Official Build) (arm64)

Revision: ec533795e8d43cd81dd0c0cff9ed1dbf23d930e2

OS: macOS Version 15.3 (Build 24D60)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@rebron rebron added feature/sync needs-investigation A bug not 100% confirmed/fixed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed needs-investigation A bug not 100% confirmed/fixed labels Jan 31, 2025
@rebron
Copy link
Collaborator

rebron commented Feb 7, 2025

cc: @AlexeyBarabash

@kjozwiak
Copy link
Member

The above requires 1.75.176 or higher for 1.75.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.75.176 Chromium: 133.0.6943.54 (Official Build) (64-bit)
-- | --
Revision | e6801717df1140ddca5688337974f103e95ed307
OS | Windows 10 Version 22H2 (Build 19045.5371)

Using the STR/Cases outlined via brave/brave-core#27450 (comment) & #43635 (comment), ensured that the Word count was working as expected as per the following:

Ensuring that the correct Word count is being displayed via Sync Chain Code

Previous Profile 1.75.175 Upgraded Profile 1.75.176
Image Image

New Profile 1.75.176

Image

Ensuring that the correct Word count is being used when entering Sync Chain Code manually

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment