Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove [Ad] from the Advertiser title #3769

Closed
mandar-brave opened this issue Mar 18, 2019 · 1 comment · Fixed by brave/brave-core#1998
Closed

Remove [Ad] from the Advertiser title #3769

mandar-brave opened this issue Mar 18, 2019 · 1 comment · Fixed by brave/brave-core#1998
Assignees
@tmancey
Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@mandar-brave
Copy link

Revert Ad notification to original spec.
Remove [Ad] from the Advertiser title. Please uplift on fix.

@jsecretan @tmancey
@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/ads labels Mar 18, 2019
@tmancey tmancey self-assigned this Mar 18, 2019
@tmancey tmancey added the QA/Yes label Mar 18, 2019
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 18, 2019
@tmancey tmancey mentioned this issue Mar 18, 2019
Merged
19 tasks
tmancey added a commit to brave/brave-core that referenced this issue Mar 18, 2019
@tmancey
Remove [Ad] from the Advertiser title
51a8f36 
fixes brave/brave-browser#3769
tmancey added a commit to brave/brave-core that referenced this issue Mar 18, 2019
@tmancey
Remove [Ad] from the Advertiser title
68cf75a 
fixes brave/brave-browser#3769
@tmancey tmancey mentioned this issue Mar 18, 2019
Merged
tmancey added a commit to brave/brave-core that referenced this issue Mar 20, 2019
@tmancey
Remove [Ad] from the Advertiser title
67b33ba 
fixes brave/brave-browser#3769
@tmancey tmancey mentioned this issue Mar 28, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 28, 2019 •
edited by srirambv
Loading

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Screen Shot 2019-03-28 at 4 32 39 PM

Verificaton passed on

Brave 0.63.24 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

Verifcation passed on both

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
Brave 0.64.36 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Screenshot from 2019-04-04 16-19-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Remove [Ad] from the Advertiser title brave/brave-core
6 participants
@tmancey @rebron @srirambv @LaurenWags @mandar-brave @GeetaSarvadnya