Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Leo] Regenerate function is working only towards the last query #36659

Closed
hffvld opened this issue Mar 9, 2024 · 2 comments · Fixed by brave/brave-core#22517
Closed

[Leo] Regenerate function is working only towards the last query #36659

hffvld opened this issue Mar 9, 2024 · 2 comments · Fixed by brave/brave-core#22517

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 9, 2024

Description:

The Regenerate function is working only towards the last query.

Steps to Reproduce

  1. Launch Brave
  2. Open Leo
  3. Ask a few questions and receive the answers
  4. Tap and hold on any response that is not the last one in a raw
  5. Regenerate > Observe it's regenerating the response for the last query instead

Actual result:

The Regenerate function is working only towards the last query.

2024-03-08_16-34-25.mp4

Expected result:

The Regenerate function must create a new response for the specific query.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.63 (171)
BraveCore: 1.63.171 (122.0.6261.111)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? N/A
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details:

iPhone 14 / iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@kjozwiak
Copy link
Member

The above requires 1.63.173 or higher for 1.63.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 13, 2024
@hffvld
Copy link
Contributor Author

hffvld commented Mar 13, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.63 (173)
BraveCore: 1.63.173 (122.0.6261.111)

STEPS:

  1. Followed the steps from [Leo] Regenerate function is working only towards the last query #36659 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Regenerate function works towards any query.

2024-03-13_15-33-36.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants