Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production url on release channel for Manage Subscriptions (active credentials) #36653

Closed
Uni-verse opened this issue Mar 8, 2024 · 2 comments · Fixed by brave/brave-core#22517

Comments

@Uni-verse
Copy link
Contributor

Description:

Currently we are sending users to account.bravesoftware.com when tapping on Manage Subscriptions in the Leo settings menu for users that have active credentials loaded. Although this only happens in TF builds and should not be the case for store published builds, we would like to test using production site on release channel only.

Steps to Reproduce

  1. Enable Leo
  2. Load active credentials from account.brave.com
  3. Open menu, select Manage Subscription
  4. Observe URL

Actual result:

account.bravesoftware.com

Expected result:

account.brave.com

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

1.63 (171)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? No
  • Can you reproduce this issue with the current build from AppStore? No

Device details:

iPhone 12, iOS 17

@kjozwiak
Copy link
Member

The above requires 1.63.173 or higher for 1.63.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Mar 14, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.63 (173)
BraveCore: 1.63.173 (122.0.6261.111)

STEPS:

  1. Follow the steps from Use production url on release channel for Manage Subscriptions (active credentials) #36653 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that account.brave.com is used when tapping Manage Subscriptions in the Leo menu

2024-03-14_14-40-16.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants