Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include synced history entries into P3A #35579

Closed
AlexeyBarabash opened this issue Jan 25, 2024 · 5 comments · Fixed by brave/brave-core#21623
Closed

Include synced history entries into P3A #35579

AlexeyBarabash opened this issue Jan 25, 2024 · 5 comments · Fixed by brave/brave-core#21623
Assignees
Labels

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Jan 25, 2024

Currently Brave.Sync.SyncedObjectsCount P3A metric doesn't include statistic for History, because SyncServiceImpl::GetEntityCountsForDebugging doesn't include that.

History is the most consuming datatype and it is vital to know the statistics.

@kjozwiak
Copy link
Member

The above requires 1.62.165 or higher for 1.62.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.62.165 Chromium: 121.0.6167.184 (Official Build) (64-bit)
-- | --
Revision | 646e9a49ef45084cb2341eb1e9afabc339004a27
OS | Windows 10 Version 22H2 (Build 19045.3930)

Example Example
image image
  • Confirmed that the metrics SyncedObjectsCount response value is 1 after following the steps 3 to 7
    image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 14, 2024

Verification PASSED on Samsung galaxy version 12 running Bravemonoarm64.apk_1.62.165

Example Example Example
Screenshot_20240214_172419_Brave Screenshot_20240214_172424_Brave Screenshot_20240214_172601_Brave

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 14, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 14, 2024

@AlexeyBarabash As per my discussion with @deeppandya we can't verify brave://inspect/#extensions on Android hence we will not be able to verify the steps 3 to 7 (from brave/brave-core#21623) on Android. Hence we are skipping the steps 3-7 verification on Android. Let us know if you know any alternatives I can verify from my end.

cc: @kjozwiak @LaurenWags

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2024
@AlexeyBarabash
Copy link
Contributor Author

@GeetaSarvadnya
This is fine to verify on Desktop only.
There is no way to make good test plan on Android.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants