Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polish to url bar icons with rounded square corners #34957

Closed
rebron opened this issue Dec 18, 2023 · 5 comments · Fixed by brave/brave-core#21464
Closed

Add polish to url bar icons with rounded square corners #34957

rebron opened this issue Dec 18, 2023 · 5 comments · Fixed by brave/brave-core#21464
Assignees
Labels
misc/icons OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 18, 2023

Description

The icons in the url bar are too round and should use our square icon design for consistency.

Design

image

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. misc/icons QA/Yes release-notes/include labels Dec 18, 2023
@rebron rebron assigned rebron and simonhong and unassigned rebron Dec 18, 2023
@simonhong
Copy link
Member

Working now.

@stephendonner
Copy link

stephendonner commented Jan 8, 2024

Verification PASSED using

Brave | 1.63.101 Chromium: 120.0.6099.199 (Official Build) nightly (x86_64)
-- | --
Revision | 8d3f0a563e185b6a763cc8e210ab24775dfb9047
OS | macOS Version 14.3 (Build 23D5043d)

Steps:

  1. installed 1.63.101
  2. launched Brave
  3. launched new windows and set up the conditions (pinned sites, brave://settings, etc.)
  4. repeat the above but in Dark mode
Light Dark
Screenshot 2024-01-08 at 1 12 47 PM Screenshot 2024-01-08 at 1 10 00 PM

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 8, 2024
@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 9, 2024
@stephendonner
Copy link

I spun off the oblong, circular site-permissions "bubbles" over in #35191.

@kjozwiak
Copy link
Member

Removing QA Pass-macOS as the above will need to be verified via 1.62.x now that it's been uplifted via brave/brave-core#21548. However, used #34957 (comment) as the needed verification for uplifting as per brave/brave-core#21548 (review).

The above requires 1.62.144 or higher for 1.62.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 16, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Jan 16, 2024

Verified with

Brave | 1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (x86_64)
-- | --
Revision | 75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS | macOS Version 13.6.3 (Build 22G436)

Reproduced the issue using 1.62.143:

Dark Theme Light Theme
dk 1 lt 1
dk 2 lt 2
dk 3 lt 3

Verified fix using 1.62.144:

Dark Theme Light Theme
2 1
4 3
6 5

Encountered #35358 with light theme, but is not caused by the PR for this issue, it is a 1.62.x regression though.

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 16, 2024
@rebron rebron changed the title Square off tune icon and other url bar icons Add polish to url bar icons with rounded square corners Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/icons OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants