Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC table not working if min visit is set to 1min #3320

Closed
NejcZdovc opened this issue Feb 12, 2019 · 3 comments · Fixed by brave/brave-core#1507
Closed

AC table not working if min visit is set to 1min #3320

NejcZdovc opened this issue Feb 12, 2019 · 3 comments · Fixed by brave/brave-core#1507

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. clean profile
  2. enable rewards
  3. set min visit to 1min
  4. restart browser
  5. go to site and stay there for 2min
  6. open new tab and visit a site for 2min
  7. go to rewards and check ac table

Actual result:

no entry into the db

Expected result:

image
(in this image min visit was set to 8s)

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@kjozwiak
Copy link
Member

@NejcZdovc was this a regression or a new issue that appeared in 0.60.x?

@NejcZdovc
Copy link
Contributor Author

@kjozwiak this issue was uncovered when we fixed #3134

@btlechowski
Copy link

btlechowski commented Feb 19, 2019

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Used STR from description.

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux
  • Verified steps from issue

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X
  • Verified steps to reproduce from issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants