Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import of passwords or cookies from muon or chrome fails #3112

Closed
LaurenWags opened this issue Jan 25, 2019 · 6 comments · Fixed by brave/brave-core#1470
Closed

import of passwords or cookies from muon or chrome fails #3112

LaurenWags opened this issue Jan 25, 2019 · 6 comments · Fixed by brave/brave-core#1470
Assignees
@darkdh
Labels
feature/importer OS/macOS priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-macOS QA/Yes regression release/blocking release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@LaurenWags
Copy link
Member

Description

Importing passwords and/or cookies from muon or Chrome fails. It seems this broke with CR72.

0.58.8 Beta (on CR71) --> Import of passwords/cookies works
0.59.9 Beta (on CR72) --> Import of passwords/cookies fails

Additionally, when importing all data (history, payments info, tabs, etc) from muon, once the password import failed, nothing else was imported. Unsure if it should have continued to import remaining items.

Steps to Reproduce

  1. have a profile set up on muon with at least passwords and cookies (mine has everything - bookmarks, payment data, etc)
  2. Launch 0.59.30 with a clean profile.
  3. Attempt to import everything. Note - I was prompted for my computer password since I’m on macOS and yes, I did provide it.

Actual result:

Passwords (and everything after it in the import list) is not imported.
Additionally, you can clear the profile and repeat STR (uncheck passwords this time) and see that Cookies (and everything after it in the list) is not imported.
Same happens for importing from Chrome.

Expected result:

Passwords and Cookies should be imported from both muon and Chrome.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

But occurs on all CR72 instances of Brave

Reproducible on current release: - does not reproduce on 0.58.21

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Reproduced by @kjozwiak on macOS
@LaurenWags LaurenWags added feature/importer release/blocking priority/P1 A very extremely bad problem. We might push a hotfix for it. release-notes/exclude regression labels Jan 25, 2019
@LaurenWags LaurenWags added this to the 0.59.x - Release milestone Jan 25, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 25, 2019 •
edited
Loading

Looks like this is a macOS specific issue. As @LaurenWags mentioned above, I could reproduce this easily on macOS 10.14.2 x64 using 0.59.30 Chromium: 72.0.3626.71 but can't reproduce it on my Win 10 x64 machine. Example:

importing

Platform Results:

  • Win 10 x64 (physical machine) - Couldn't reproduce after several imports
  • Win 8.1 x64 VM - Couldn't reproduce after several imports
  • Mint 19.1 x64 VM - Couldn't reproduce after several imports

@kjozwiak
Copy link
Member

@btlechowski mind giving this a go on your Win 7 machine to see if you can reproduce? Seems to be working on Win on my end. Would be nice to get another set of eyes on Win 👍

@darkdh darkdh self-assigned this Jan 27, 2019
darkdh added a commit to brave/brave-core that referenced this issue Jan 27, 2019
@darkdh
Check key_creation_util_ in importer utility process
246d220 
fix brave/brave-browser#3112

Upstream commit:
commit f1ab93849fe9436e27b27ad76d59369a6ad40ce9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date:   Thu Nov 22 15:54:53 2018 +0000

    Delete kPreventEncryptionKeyOverwrites feature.

    The feature is not to be launched and the associated code is
    removed.
    The metrics collection should be running.
@darkdh darkdh mentioned this issue Jan 27, 2019
Merged
18 tasks
bbondy pushed a commit to brave/brave-core that referenced this issue Jan 28, 2019
@darkdh @bbondy
Check key_creation_util_ in importer utility process
b77d3ab 
fix brave/brave-browser#3112

Upstream commit:
commit f1ab93849fe9436e27b27ad76d59369a6ad40ce9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date:   Thu Nov 22 15:54:53 2018 +0000

    Delete kPreventEncryptionKeyOverwrites feature.

    The feature is not to be launched and the associated code is
    removed.
    The metrics collection should be running.
bbondy pushed a commit to brave/brave-core that referenced this issue Jan 28, 2019
@darkdh @bbondy
Check key_creation_util_ in importer utility process
b434fa0 
fix brave/brave-browser#3112

Upstream commit:
commit f1ab93849fe9436e27b27ad76d59369a6ad40ce9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date:   Thu Nov 22 15:54:53 2018 +0000

    Delete kPreventEncryptionKeyOverwrites feature.

    The feature is not to be launched and the associated code is
    removed.
    The metrics collection should be running.
bbondy pushed a commit to brave/brave-core that referenced this issue Jan 28, 2019
@darkdh @bbondy
Check key_creation_util_ in importer utility process
50219b8 
fix brave/brave-browser#3112

Upstream commit:
commit f1ab93849fe9436e27b27ad76d59369a6ad40ce9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date:   Thu Nov 22 15:54:53 2018 +0000

    Delete kPreventEncryptionKeyOverwrites feature.

    The feature is not to be launched and the associated code is
    removed.
    The metrics collection should be running.
This was referenced Jan 28, 2019
Merged
Merged
Merged
@bbondy bbondy added the QA/Yes label Jan 28, 2019
@btlechowski
Copy link

@kjozwiak I was not able to reproduce it on 0.59.30 Windows 7 x64 and Windows 10 x64.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 28, 2019 •
edited
Loading

Issue is NOT Reproducible on Windows 10 x64. Tested on below builds:

  • Import muon data from 0.25.304 to Brave 0.59.30 - PASS
  • Import muon data from 0.25.304 to Brave beta 0.59.28 - PASS
  • Import muon data from 0.25.304 to Brave 0.58.21 - PASS

@LaurenWags
Copy link
Member Author

LaurenWags commented Jan 28, 2019 •
edited
Loading

Verified passed with

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X
  • Verified able to import cookies and passwords from muon (0.25.304)
  • Verified able to import cookies and passwords from Chrome (71.0.3578.98)
    cc @kjozwiak for double check on his mac

@kjozwiak kjozwiak mentioned this issue Jan 30, 2019
Closed
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

Went through the following cases:

  • logged into FB, Gmail, Comic Geeks, Fantasy PL under muon and imported into 0.59.x
  • logged into FB, Gmail, Comic Geeks, Fantasy PL under Chrome and imported into 0.59.x
  • ensured that I was still logged into and that the passwords were also imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/importer OS/macOS priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-macOS QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Check key_creation_util_ in importer utility process brave/brave-core
6 participants
@bbondy @kjozwiak @darkdh @LaurenWags @btlechowski @GeetaSarvadnya