Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface script blocking shortcuts to "Allow once", fix scripts functionality, focus indicators, and scroll #2996

Closed
karenkliu opened this issue Jan 16, 2019 · 4 comments
Closed

Surface script blocking shortcuts to "Allow once", fix scripts functionality, focus indicators, and scroll #2996

karenkliu opened this issue Jan 16, 2019 · 4 comments
Assignees
@karenkliu @cezaraugusto
Labels
design A design change, especially one which needs input from the design team feature/shields/!scripts Blocking JavaScript with Shields priority/P3 The next thing for us to work on. It'll ride the trains.
Milestone
Closed / Dupe / I...

Comments

@karenkliu
Copy link

karenkliu commented Jan 16, 2019 •
edited
Loading

Description

  • Make script blocking shortcuts to "Allow once" as easy to access as Muon (legacy). Previously it took 2 clicks in Muon:
    noscript.mov.zip
    The current design takes 3 clicks:
    1. Click on the shields icon
    2. Click on the scripts dropdown
    3. Click "Allow all" link
  • Fix functionality in scripts detail view so that users can allow/block all sources of Javascript or select individual sources to allow/block
  • Enable scrolling on the detailed view
  • Fix focus indicators

Designs

shields scripts breakdown

When looking at the scripts detail view, we should enable horizontal scrolling so that someone can see the full FQDN.
registered domain explanation
If it's longer than the content area, the additional text to the left of the registered domain (ETLD+1) is initially truncated as an ellipses. In this new design, we do not show the path or "https://" at all. Only the full FQDN or (...)(registered domain) is shown.

scroll behavior

All interactive UI elements in the scripts detail view should have keyboard support and the appropriate focus treatment.
scripts focus states

The interface should accommodate long strings when translated. For example, the strings in the Shields panel translated to Russian should wrap like this:
long string

Grab the SVG assets from this ZIP folder:
icons.zip

For more CSS and plain text, check Abstract link: https://share.goabstract.com/68d70c4d-8c77-4588-9ee5-ce6418505c79

Theme Update

Since we enabled light/dark theme switching in a quick fix, here is the updated color theming for your reference:
shields theme update
Abstract link: https://share.goabstract.com/bb5e3286-b046-4276-9651-37768069932e
@karenkliu karenkliu added design A design change, especially one which needs input from the design team feature/shields/!scripts Blocking JavaScript with Shields labels Jan 16, 2019
@karenkliu karenkliu self-assigned this Jan 16, 2019
@rebron rebron added this to the 1.x Backlog milestone Jan 18, 2019
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jan 24, 2019
@karenkliu karenkliu changed the title Surface script blocking shortcuts to "Allow once" and "Allow until restart" Surface script blocking shortcuts to "Allow once" and "Allow until restart" and fix scripts usability issues Jan 24, 2019
@karenkliu karenkliu changed the title Surface script blocking shortcuts to "Allow once" and "Allow until restart" and fix scripts usability issues Surface script blocking shortcuts to "Allow once" and "Allow until restart" and fix scripts functionality Jan 24, 2019
@karenkliu karenkliu changed the title Surface script blocking shortcuts to "Allow once" and "Allow until restart" and fix scripts functionality Surface script blocking shortcuts to "Allow once", fix scripts functionality, focus indicators, and scroll Jan 24, 2019
@karenkliu karenkliu mentioned this issue Jan 24, 2019
Closed
This was referenced Feb 6, 2019
Closed
Closed
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@karenkliu karenkliu mentioned this issue Feb 15, 2019
Closed
@karenkliu karenkliu mentioned this issue Mar 8, 2019
Closed
@cezaraugusto cezaraugusto self-assigned this Mar 18, 2019
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 18, 2019
@karenkliu
Copy link
Author

Added dash.svg to the zipped folder per Cezar's feedback.

@cezaraugusto cezaraugusto mentioned this issue May 15, 2019
Closed
6 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue May 23, 2019
@cezaraugusto
change logic of noScript interactions
50aa365 
-
blocking a script now takes effect immeditately.
scripts blocked now go to the blocked list only after second interaction
address brave/brave-browser#2996
@cezaraugusto cezaraugusto mentioned this issue May 23, 2019
Merged
6 tasks
@cezaraugusto cezaraugusto mentioned this issue May 23, 2019
Closed
This was referenced May 23, 2019
Closed
Closed
Open
Closed
cezaraugusto added a commit to brave/brave-core that referenced this issue May 23, 2019
@cezaraugusto
add new noScript interface
c2d074c 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

address brave/brave-browser#2996
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
@cezaraugusto
change logic of noScript interactions
3ca12b4 
-
blocking a script now takes effect immeditately.
scripts blocked now go to the blocked list only after second interaction
address brave/brave-browser#2996
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
@cezaraugusto
add new noScript interface
2cb0d16 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 5, 2019
@cezaraugusto @bsclifton
change logic of noScript interactions
30358e3 
-
blocking a script now takes effect immeditately.
scripts blocked now go to the blocked list only after second interaction
address brave/brave-browser#2996
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 5, 2019
@cezaraugusto @bsclifton
add new noScript interface
86d5b33 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
@cezaraugusto
Copy link
Contributor

@karenkliu could you please take a look at this and check what items remain missing? It would be best if we can split them into multiple smaller issues.

@cezaraugusto
Copy link
Contributor

At a quick glance, it seems only full FQDN display is missing, but I can be possibly wrong.

@cezaraugusto
Copy link
Contributor

FQDN was split from here a while ago #4574. I did a new check and it does seem it's the only item left. I'm going to close this one for now but please re-open if I'm mistaken.

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team feature/shields/!scripts Blocking JavaScript with Shields priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
5 participants
@tildelowengrimm @bbondy @karenkliu @cezaraugusto @rebron