Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-contribute table is not visually updated in brave://rewards after reactivating rewards #2892

Closed
btlechowski opened this issue Jan 10, 2019 · 2 comments · Fixed by brave/brave-core#1487

Comments

@btlechowski
Copy link

Note: This is a visual bug.

Steps to Reproduce

  1. Clean profile
  2. Run Brave with flag --rewards=staging=true,reconcile-interval=2
  3. Enable rewards brave://rewards and claim the grant
  4. Open kjozwiakstaging.github.io in a new tab and stay on it for 10s to add it to a-c table
  5. Disable rewards
  6. Wait till the reconcile-interval is passed (2 minutes)
  7. Enable rewards

Actual result:

kjozwiakstaging.github.io is visible in the auto-contribute table
auto-contribute table is not visually updated
Note: reloading brave://rewards will update the auto-contribute table and kjozwiakstaging.github.io will be gone
Note: adding another site (like duckduckgo.com) will update the table

Expected result:

kjozwiakstaging.github.io is not visible in the auto-contribute table
auto-contribute table is visually updated

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

cc @NejcZdovc @mandar-brave @brave/legacy_qa

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 10, 2019

Able to reproduce the issue.
Even if you don't reload the page, sites gets cleared from a-c table after few minutes, which leads to confusion that auto contribution happened and a-c total balance did not go down.

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 10

@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Jan 19, 2019
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 21, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 29, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Jan 29, 2019
@btlechowski
Copy link
Author

btlechowski commented Feb 26, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1487.
Also tested with a-c off instead of rewards off.
Verified that after reconciliation happens when rewards are off, reconciliation can happen when rewards are re-enabled.

Verification passed on

Brave 0.61.40 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint
  • Verified the test plan from Updates settings page data when re-enabling rewards brave-core#1487 ( a-c is OFF/Disabled)
  • Verified that after reconcile-interval, the a-c table gets cleared when the monthly budget is higher
    than the total wallet balance
  • Verified that after reconcile-interval, the a-c table gets cleared (Happy path)
  • Verified that after reconcile-interval, the a-c table gets cleared when Brave Rewards is OFF

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X
  • Verified test plan from Updates settings page data when re-enabling rewards brave-core#1487 (once with original steps, once with only Auto Contribute toggled off instead of all of Rewards module)
  • Verified that after designated contribution time occurs when rewards are off, contribution can happen when rewards are re-enabled (and site(s) are added to the table appropriately)
  • Verified that after reconcile-interval, the a-c table gets cleared when the monthly budget is higher than the total wallet balance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants