Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher banner: incorrect letter used thank you banner #2718

Closed
mandar-brave opened this issue Dec 23, 2018 · 2 comments · Fixed by brave/brave-core#1410
Closed

Publisher banner: incorrect letter used thank you banner #2718

mandar-brave opened this issue Dec 23, 2018 · 2 comments · Fixed by brave/brave-core#1410

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 23, 2018

Test Plan

brave/brave-core#1410

When tipping unverified/verified YT channel, the thank you screen shows a “Y” in a circle, vs the first letter of the channel.
Need to use the first letter of the channel consistently across tip-banner and thank-you-banner.

cc @davidtemkin @NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 23, 2018
@jonathansampson
Copy link
Contributor

This applies to verified publishers too:

image

@mandar-brave mandar-brave changed the title Unverified publisher: incorrect letter used thank you banner Publisher banner: incorrect letter used thank you banner Dec 23, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 23, 2018
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Dec 27, 2018
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 19, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 22, 2019
@btlechowski
Copy link

btlechowski commented Feb 14, 2019

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

For some verified publishers there is no icon at all. Logged: #3364

Unverified publishers are shown with the proper letter.
Channel URL: https://www.youtube.com/channel/UCwRMYIQ89FhDouMEASM5uAA
Channel name: MrShoptaw
Banner:
image

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux
  • Unverified pubs shown with first letter for both media and non media publishers

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

Went through the following cases and ensured that the correct icon/letter is being used under the Thank You banner when tipping:

Unverified YT Channels - **PASSED**

* https://www.youtube.com/channel/UCCatR7nWbYrkVXdxXb4cGXw
* https://www.youtube.com/channel/UCyRhIGDUKdIOw07Pd8pHxCw
* https://www.youtube.com/user/boardgamegeektv

Verified YT Channels - **PASSED**

* https://www.youtube.com/user/sxephil
* https://www.youtube.com/channel/UCazMm3tOCkYrIGE_17j0mVg
* https://www.youtube.com/user/vice

Unverified Websites - **PASSED**

* https://www.reddit.com/
* https://twitter.com/
* https://facebook.com/

Verified Websites - **PASSED**

* https://clifton.io/
* https://coinpaprika.com/
* bodybuilding.com/

Unverified Twitch Channels - **PASSED**

* https://www.twitch.tv/shipwreckfive
* https://www.twitch.tv/timthetatman
* https://www.twitch.tv/tfue

Verified Twitch Channels - **PASSED**

* https://www.twitch.tv/psherotv
* https://www.twitch.tv/bwana
* https://www.twitch.tv/themattayahu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants