Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-play blocked on rainway and cheddar.com #2522

Closed
andrewmd5 opened this issue Dec 13, 2018 · 6 comments · Fixed by brave/brave-core#1538
Closed

Auto-play blocked on rainway and cheddar.com #2522

andrewmd5 opened this issue Dec 13, 2018 · 6 comments · Fixed by brave/brave-core#1538

Comments

@andrewmd5
Copy link

Description

When starting a real-time interactive video stream from Rainway, the video and audio is blocked from playing by default even though it utilizes MSE and the creation was triggered by a user action.

Steps to Reproduce

  1. Start a game stream.
  2. The video is blocked from playing.

Actual result:

Expected result:

Immediate playback of the audio/video content so the user can interact with the remote content.

Reproduces how often:

Until setting it to allow auto-play.

Brave version (brave://version info)

Brave 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

Reproducible on current release:

Yes

Website problems only:

Chrome, Firefox, and Safari all play the video/audio content without issue.

Additional Information

N/A

@andrewmd5 andrewmd5 changed the title Auto-play blocked on user triggered interaction Auto-play blocked on user triggered interaction. Dec 13, 2018
@srirambv
Copy link
Contributor

Autoplay is blocked by default. That the expected behaviour. Unless the domain is whitelisted it will always block on clean load. Here's a list of sites that are whitelisted (#1089)

Closing as this is the expected behaviour.

@srirambv srirambv added this to the Dupe / Invalid / Not actionable milestone Dec 13, 2018
@andrewmd5
Copy link
Author

Just for reference blocking by default isn’t spec compliant as all other browsers trigger it based on site usage and user interaction, not whitelisting. There is also zero clear notification on the UI so this will break any video based screen sharing applications.

@andrewmd5
Copy link
Author

andrewmd5 commented Dec 21, 2018

Bumping this again as we've had 6 user reports in the last week as to way manual action is required to start real-time playback in Brave. User interaction is an intent to trigger playback and there is no reason that should be blocked.

@srirambv
Copy link
Contributor

cc: @bbondy to comment on adding the said site on whitelist.

@srirambv srirambv reopened this Jan 29, 2019
@srirambv srirambv modified the milestones: Dupe / Invalid / Not actionable, 1.x Backlog Jan 29, 2019
@bbondy bbondy changed the title Auto-play blocked on user triggered interaction. Auto-play blocked on rainway Feb 1, 2019
@bbondy bbondy changed the title Auto-play blocked on rainway Auto-play blocked on rainway and cheddar.com Feb 1, 2019
@bbondy bbondy changed the title Auto-play blocked on rainway and cheddar.com Auto-play blocked on rainway.io and cheddar.com Feb 1, 2019
@bbondy bbondy changed the title Auto-play blocked on rainway.io and cheddar.com Auto-play blocked on rainway and cheddar.com Feb 1, 2019
@bbondy bbondy added the QA/Yes label Feb 1, 2019
@bbondy
Copy link
Member

bbondy commented Feb 1, 2019

0.59.x is already out the door but I put this to be uplifted to Beta channel for you @Codeusa.
It'll be in the next Beta build.
Cheers!

@bbondy bbondy modified the milestones: 1.x Backlog, 0.60.x - Beta Feb 1, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 13, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified navigating to cheddar.com and selecting a stream to play did not show autoplay icon in URL bar as it did on 0.59.35. Verified videos autoplayed on cheddar articles.
  • Verified navigating to rainway.com and playing the video on home page did not show autoplay icon in URL bar as it did on 0.59.35.

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10
  • Verified the STR mentioned in the description

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux Mint

  • Verified the STR mentioned in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants