Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Don't ask me again" setting in "Close all tabs?" prompt has no effect from private window #24829

Closed
oldhen opened this issue Aug 19, 2022 · 2 comments · Fixed by brave/brave-core#14734

Comments

@oldhen
Copy link

oldhen commented Aug 19, 2022

Description

When closing a private window with multiple tabs open, the Don't ask me again setting in the Close all tabs? prompt has no effect.

Steps to Reproduce

  1. Ensure Warn me before closing window with multiple tabs setting is on
  2. Open a private window
  3. Open multiple tabs
  4. Close private window
  5. Select Don't ask me again setting when prompted with Close all tabs?
  6. Open a private window
  7. Open multiple tabs
  8. Close private window

Actual result:

  • Close all tabs? prompt appears
  • Warn me before closing window with multiple tabs setting is still on

Expected result:

  • Private window should close without prompt
  • Warn me before closing window with multiple tabs setting should be off

Reproduces how often:

Always

Brave version (brave://version info)

  • 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
  • Windows 10 Version 21H2 (Build 19044.1889)
@bsclifton
Copy link
Member

bsclifton commented Aug 22, 2022

cc: @simonhong

@simonhong simonhong self-assigned this Aug 22, 2022
simonhong added a commit to brave/brave-core that referenced this issue Aug 22, 2022
…n't work

fix brave/brave-browser#24829

Setting prefs to private profile is not persisted.
Always set it to orignal profile.
@simonhong simonhong added this to the 1.44.x - Nightly milestone Aug 23, 2022
@stephendonner stephendonner changed the title "Don't ask me again" setting in "Close all tabs?" prompt has no affect from private window "Don't ask me again" setting in "Close all tabs?" prompt has no effect from private window Aug 31, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.44.70 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified and reproduced the issue using STR from #24829 (comment)

1.42.83 Chromium: 104.0.5112.69

Ex1 Ex2 Ex3 Ex4
image image image image

####Steps:

  1. Install 1.44.70
  2. launch Brave
  3. ensure Warn me before closing window with multiple tabs setting is oninbrave://settings/braveHelpTips`
  4. click Hamburger menu to open New Private Window
  5. open multiple tabs in the private window
  6. click x to close the private window
  7. check the check box for Don't ask me again setting in Close all tabs? modal
  8. confirmed Warn me before closing window with multiple tabs toggle is OFF
  9. run above steps 4-6 again

####Confirmed private window closed without Close all tabs? modal

step 3 step 4 step5-7 step8 step9
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment