Website added via Add site modal is not added to NTP

[MadhaviSeelam]

Description

Steps to Reproduce

1. Install 1.43.54
2. launch Brave
3. visit a websites (bbc.com)
4. open a new tab page
5. bbc.com is added to NTP
6. click ... in the same view box/row as the websites
7. click Add site
8. add website information in the modal (usatoday.com) and save

Actual result:

Website (usatoday) is not shown on NTP

2022-08-01_14h27_58.mp4

Expected result:

Website should be shown along with correct favicon

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.43.54 Chromium: 104.0.5112.69 (Official Build) beta (64-bit)
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Windows 11 Version 21H2 (Build 22000.795)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @rebron

[fallaciousreasoning]

Sounds quite similar to brave/brave-core#14293. Would you mind checking in the latest Nightly to see if it reproduces?

[MadhaviSeelam]

@fallaciousreasoning yes, it is reproducible in 1.44.12.
So the behavior in both 1.44.x and 1.43.x is

1. click ... --->Add site ---> site is not aded
2. click show favorites-->Add site-->sites gets added to NTP
3. now click ...-->Add site-->site gets added to NTP

[fallaciousreasoning]

👍 I'll take a look

[stephendonner]

Verified PASSED using

Brave	1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	macOS Version 13.0 (Build 22A5331f)

Steps:

1. installed 1.44.73
2. launched Brave
3. loaded bbc.com
4. open a new tab page
5. confirmed bbc.com is added to the NTP
6. clicked ... in the same view box/row as the websites
7. clicked Add site
8. added website information in the modal (usatoday.com) and clicked Save
9. clicked on the usatoday.com favorite

Confirmed it made and successfully loaded the usatoday.com favorite

example	example	example	example	example	example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
-- | --
Revision | 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS | Windows 11 Version 21H2 (Build 22000.978)

Followed my original steps from the description

1. Installed 1.44.93
2. launched Brave
3. visited a website (https://bbc.com)
4. opened a new tab page
5. BBC is added to NTP
6. click ... in the same view box/row as the website
7. clicked Add site
8. added website information in the modal (https://usatoday.com) and save
9. confirmed usatoday added to NTP favorites
10. clicked on the favorite (usatoday) to verify page is loaded
11. return to NTP to confirm the usatoday favicon displayed

step 3	step 5	step 7	step 8	step 9	step 10	step 11