Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS interstitial is not shown when redirect from .eth domains #24188

Closed
cypt4 opened this issue Jul 21, 2022 · 1 comment · Fixed by brave/brave-core#14424
Closed

IPFS interstitial is not shown when redirect from .eth domains #24188

cypt4 opened this issue Jul 21, 2022 · 1 comment · Fixed by brave/brave-core#14424
Assignees
@cypt4
Labels
bug feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@cypt4
Copy link

cypt4 commented Jul 21, 2022

Steps to Reproduce

  1. Set IPFS resolve option to "Ask"
  2. Navigate to vitalik.eth
  3. Check omnibox url. Remote gateway is loaded
@cypt4 cypt4 self-assigned this Jul 21, 2022
@cypt4 cypt4 added QA/Yes feature/web3/ipfs priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 21, 2022
@cypt4 cypt4 mentioned this issue Jul 21, 2022
Closed
@cypt4 cypt4 mentioned this issue Aug 2, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Aug 3, 2022
@cypt4
Show IPFS interstitial after url switching
584c58f 
Resolves brave/brave-browser#24188
At the moment IPFS interstitial for the "Ask" option is shown
only when navigation is started and url has ipfs scheme.
If url changes after that(for ex. after UD or ENS resoulution)
interstitial won't be shown after that.
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 5, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.44.29 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Steps:

  1. installed 1.44.29
  2. launched Brave
  3. loaded vitalik.eth
  4. clicked on Proceed using Infrura server
  5. confirmed I got the interstitial page
  6. set Method to resolve IPFS resources to Disabled on brave://settings/ipfs
step 3-4 step 5 step 6
Screen Shot 2022-08-08 at 4 01 52 PM Screen Shot 2022-08-08 at 3 56 58 PM Screen Shot 2022-08-08 at 3 57 22 PM
  1. loaded vitalik.eth

Confirmed I got the the following error message:

Screen Shot 2022-08-08 at 3 57 30 PM

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
bug feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Brave 24166 brave/brave-core
3 participants
@stephendonner @brave-builds @cypt4