Add setting to allow separate search engine usage for Private Window

[rebron]

Description

Users should be able to specify their search engine of choice in Private Windows. In brave://settings/search, add a new setting under "Search engine used in address bar" to allow users to use a different search engine in Private Windows separate from Normal Windows.

The list for Private Windows should be the same as Normal Windows as specified per locale.
The default for Private Windows should be Brave Search for all regions.

Expected Result

1. Go to brave://settings/search
2. Be able to select a search engine of choice for Private Windows. For QA, notice that Brave Search is the default choice. Choose a different search engine from that list.
3. Open a new private window. Notice the favicon upon entering the address bar matches the search engine of choice setting. Perform a search and notice the search results come from the selected search engine from step 2.

Design:

#23091 (comment)

Brave version (brave://version info)

Targeted for 1.42.x

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue: #22566
This setting already exists for Android and iOS and should be syncable.

[aguscruiz]

Designs here:
https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=2169%3A45510

Screenshot for reference:

[simonhong]

@rebron Should we maintain below UI (ddg toggle button) for some existing users?
I think we don't need this anymore as we will provide separate provider list for private window and
DDG could be configured from it.
=> In this issue, this toggle button will not be touched. New search engine list option for private window will work independently with this toggle. When toggle is off, configured privider is used. Otherwise, DDG will be used.

[simonhong]

Initial default search provider:

• for ddg toggle on users: DDG
• all other existing users: normal profile's provider
• fresh user: same provider with normal profile

[rebron]

@rebron Should we maintain below UI (ddg toggle button) for some existing users? I think we don't need this anymore as we will provide separate provider list for private window and DDG could be configured from it. => In this issue, this toggle button will not be touched. New search engine list option for private window will work independently with this toggle. When toggle is off, configured privider is used. Otherwise, DDG will be used.

Yes you're correct. And will be addressed in #22566.

[stephendonner]

Verification PASSED using

Brave	1.42.62 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	macOS Version 13.0 (Build 22A5295i)

Case one: new profile - PASSED

1. install 1.42.62
2. launch Brave
3. open brave://settings/search and check Brave is the listed provider for both Normal Window and Private Window
4. expand the list and ensure search-engine order and names match the spec (they should be the same between both window types)
5. change Brave to Qwant for Private Window
6. click on the "hamburger" menu and choose New Private Window
7. perform a search and confirm you're using Qwant
8. perform a search using a Normal Window and confirm it uses Brave
9. perform a search using a Private Window with Tor and confirm it uses Brave
10. perform a search using a Guest Window and confirm it uses Brave
11. opened brave://settings/searchEngines
12. clicked on the pencil icon to edit Brave
13. changed Brave to Bravest
14. clicked Save
15. confirm the name has been updated in both Window options list
16. open brave://settings/reset
17. click on Restore settings to their original defaults
18. confirm by clicking on Reset settings
19. confirm default search providers have been restored

step 4	step 5	step 7	step 8	step 9	step 10	step 15	step 19

Case two: migrations - PASSED

From 1.41.96 to 1.42.62 - N/A

N/A without modifying `Preferences`; tested below

From 1.30.89 -> 1.40.113 -> 1.42.62 - PASSED

1. install 1.30.89
2. launch Brave
3. open a New Private Window
4. toggle Search with DuckDuckGo to On
5. shut down Brave
6. install/upgrade to 1.40.113
7. open a New Private Window
8. confirm Search with DuckDuckGo is toggled
9. perform a search and ensure DuckDuckGo is used
10. (on macOS) rename Brave-Browser to Brave-Browser-Beta
11. install/upgrade to 1.42.62
12. launch Brave
13. confirm DuckDuckGo is chosen for Private Window in brave://settings/search
14. perform a search and ensure DuckDuckGo is (still) used

step 4	step 8	step 9	step 13	step 14

From 1.30.89 -> 1.41.96 -> 1.42.62 - PASSED

From 1.30.89 (part A, -> 1.41.96)

1. install 1.30.89
2. launch Brave
3. open a New Private Window
4. toggle Search with DuckDuckGo to On
5. shut down Brave
6. trigger an update via brave://settings/help
7. confirm you get 1.41.96
8. open a New Private Window
9. confirm you see Search with DuckDuckGo toggled to On
10. perform a search and confirm you are using DuckDuckGo

step 4	step 7	step 9	step 10

(continued...)

From 1.41.96 (part B, -> 1.42.62)

11. (on macOS) rename Brave-Browser to Brave-Browser-Beta
12. launch 1.42.62
13. open a New Private Window
14. perform a search and confirm you are (still) using DuckDuckGo
15. confirm DuckDuckGo is selected for Private Window on brave://settings/search

step 14	step 15

Case three: Sync - PASSED

Shared step:

• install 1.42.62 on one desktop (A)
• install 1.42.62 on another desktop (B)

desktop (A)

1. open brave://settings/search
2. change Normal Window from Brave to Startpage
3. change Private Window from Brave to Ecosia
4. click on the "hamburger" menu, and then Sync
5. click on Start using sync
6. click on Start a new Sync Chain
7. click on Computer
8. under Sync Settings, click on the Sync everything toggle
9. copy the codewords

steps 2 & 3	step 7	step 8

desktop (B)

1. click on the "hamburger" menu, and then Sync
2. click on Start using sync
3. click I have a Sync Code
4. enter/paste the codewords from desktop (A)
5. click Confirm
6. click OK
7. under Sync Settings, click on the Sync everything toggle
8. open brave://settings/search
9. confirm Normal Window is Startpage
10. confirm Private Window is Ecosia

step 4	step 7	steps 9 & 10

[MadhaviSeelam]

Verification PASSED using

Brave | 1.42.73 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | Windows 11 Version 21H2 (Build 22000.469)

Filed #24284

Case one: new profile - PASSED

1. install 1.42.62
2. launch Brave
3. open brave://settings/search and check Brave is the listed provider for both Normal Window and Private Window
4. expand the list and ensure search-engine order and names match the spec (they should be the same between both window types)
5. change Brave to StartPage for Private Window
6. click on the "hamburger" menu and choose New Private Window
7. perform a search and confirm you're using Qwant
8. perform a search using a Normal Window and confirm it uses Brave
9. perform a search using a Private Window with Tor and confirm it uses Brave
10. perform a search using a Guest Window and confirm it uses Brave
11. opened brave://settings/searchEngines
12. Click three dots (...) for Ecosia
13. Delete Ecosia
14. confirm lists have been updated in both Window options list
15. open brave://settings/reset
16. click on Restore settings to their original defaults
17. confirm by clicking on Reset settings
18. confirm default search providers have been restored

Step 3	Step4(NW)	Step4(PW)	Step 5	Step 7	Step8	Step 9	Step 10	Step 12	Step 15	Step 19

Case two: migrations

without modifying Preferences; tested below

From 1.41.100 to 1.42.73 - PASSED

1. install 1.41.100
2. launch Brave
3. open brave://settings/search show Normal window search engine entry
4. Rename Brave-Browser to Brave-Browser-Beta
5. install 1.42.73
6. launch Brave
7. confirmed new entry for Brave is a default search provider for Private Window and user will be able to select search provider via settings in brave://settings/search
8. perform a search using a Private Window and confirmed it uses Brave

Step 1	Step 3	Step 4	Step 6	Step 7a	Step 7b

From 1.30.89 -> 1.40.113 -> 1.42.73 - PASSED

1. install 1.30.89
2. launch Brave
3. open a New Private Window
4. toggle Search with DuckDuckGo to On
5. shut down Brave
6. install/upgrade to 1.40.113
7. open a New Private Window
8. confirm Search with DuckDuckGo setting is retained and is toggled ON
9. perform a search and ensure DuckDuckGo is used
10. Rename Brave-Browser to Brave-Browser-Beta
11. install/upgrade to 1.42.73
12. launch Brave
13. DuckDuckGo toggle button is not visible anymore in private NTP
14. confirm DuckDuckGo is chosen for Private Window in brave://settings/search
15. perform a search and ensure DuckDuckGo is (still) used
16. Normal window still should show Google as a default selection

Step1	Step 4A	Step4B	Step6	Step 8	Step 9	Step 13	Step 14	Step 15

From 1.30.89 -> 1.41.96 -> 1.42.73 - PASSED

From 1.30.89 (part A, -> 1.41.100)

1. install 1.30.89
2. launch Brave
3. open a New Private Window
4. toggle Search with DuckDuckGo to On
5. trigger an update via brave://settings/help
6. confirm you get 1.41.100
7. open a New Private Window
8. confirm you see Search with DuckDuckGo toggled to On
9. perform a search and confirm you are using DuckDuckGo

Step1	Step4A	Step 4B	Step5	Step6	Step 8	Step 9

(continued...)

From 1.41.96 (part B, -> 1.42.73)

12. Rename Brave-Browser to Brave-Browser-Beta
13. launch 1.42.73
14. open a New Private Window
15. confirmed DDG toggle button is not visible anymore in private NTP
16. perform a search using a Private Window and confirm it uses DDG
17. confirmed user will be to select search provider for private profile via settings in brave://settings/search

Step 12	Step 15	Stept 16

Case three: Sync - PASSED

Verified on two profiles on the same desktop:

• profile 1
• create another profile profile 2-sync

**profile 1 **

1. open brave://settings/search
2. change Normal Window from Brave to Ecosia
3. change Private Window from Brave to Bing
4. click on the "hamburger" menu, and then Sync
5. click on Start a new Sync Chain
6. click on Computer
7. copy the codewords
8. under Sync Settings, click on the `Sync everything'

steps 2 & 3	step 7	Step 8

profile 2-sync

1. click on the "hamburger" menu, and then Sync
2. click I have a Sync Code
3. enter/paste the codewords from profile 1
4. click Confirm
5. click OK
6. under Sync Settings, click on the Sync everything toggle
7. open brave://settings/search
8. confirm Normal Window is Ecosia
9. confirm Private Window is Bing

Step 5	Step 7	Step 8&9

---

Verification passed on

Brave	1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Ubuntu 18.04 LTS

Case one: new profile - PASSED

1. install 1.42.x
2. launch Brave
3. open brave://settings/search and check Brave is the listed provider for both Normal Window and Private Window
4. expand the list and ensure search-engine order and names match the spec (they should be the same between both window types)
5. change Brave to StartPage for Private Window
6. click on the "hamburger" menu and choose New Private Window
7. perform a search and confirm you're using Qwant
8. perform a search using a Normal Window and confirm it uses Brave
9. perform a search using a Private Window with Tor and confirm it uses Brave
10. perform a search using a Guest Window and confirm it uses Brave
11. opened brave://settings/searchEngines
12. Click three dots (...) for Ecosia
13. Delete Ecosia
14. confirm lists have been updated in both Window options list
15. open brave://settings/reset
16. click on Restore settings to their original defaults
17. confirm by clicking on Reset settings
18. confirm default search providers have been restored

Case two: migrations

without modifying Preferences; tested below

From 1.41.x to 1.42.x - PASSED

1. install 1.41.x
2. launch Brave
3. open brave://settings/search show Normal window search engine entry
4. Rename Brave-Browser to Brave-Browser-Beta
5. install 1.42.x
6. launch Brave
7. confirmed new entry for Brave is a default search provider for Private Window and user will be able to select search provider via settings in brave://settings/search
8. perform a search using a Private Window and confirmed it uses Brave

Case three: Sync - PASSED

Verified on two profiles on the same desktop:

• profile 1
• create another profile profile 2-sync

**profile 1 **

1. open brave://settings/search
2. change Normal Window from Brave to Ecosia
3. change Private Window from Brave to Bing
4. click on the "hamburger" menu, and then Sync
5. click on Start a new Sync Chain
6. click on Computer
7. copy the codewords
8. under Sync Settings, click on the `Sync everything'

profile 2-sync

1. click on the "hamburger" menu, and then Sync
2. click I have a Sync Code
3. enter/paste the codewords from profile 1
4. click Confirm
5. click OK
6. under Sync Settings, click on the Sync everything toggle
7. open brave://settings/search
8. confirm Normal Window is Ecosia
9. confirm Private Window is Bing