Fix cosmetic filters not being applied inside of child frames

[ryanbr]

Description

Some cosmetics aren't being applied

Steps to Reproduce

1. Enable Fanboy Annoyances in brave://adblock
2. Open https://instapundit.com/513971/#respond
3. Expect the social elements to be filtered.

Actual result:

Expected result:

Social cosmetics should be removed/filtered out.

Reproduces how often:

Easily, when Annoyances/Social list is enabled.

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @antonok-edm

Related thread: https://community.brave.com/t/block-something-using-browser-instead-of-ublock-origin/368569/

[ryanbr]

https://www.thedailybeast.com/massachusetts-officials-confirm-first-us-monkeypox-case-this-year

<div class="Cheat__out-of-page-ads"> not being filtered/hidden

[mckealty]

Hi all! I promise I am not being pushy, I have never submitted a bug/request before so I was wondering how long something like this usually takes.

I appreciate this being submitted for me, I would like to rely on as few addons as possible and this will help.

Thank you again.

[antonok-edm]

I'm not able to reproduce the first issue - @mckealty if you're still experiencing it could you please post more information about your browser version and Shields settings? Just noticed there were two sets of share buttons, this issue refers to the Disqus ones. Those are still appearing, and adding instapundit.com##.share-bar doesn't fix it.

As per the second issue - I don't see any .Cheat__out-of-page-ads elements unhidden, but I do see that ##.Cheat__top-ad isn't working and thedailybeast.com##.Cheat__top-ad is required to fix it.

[mckealty]

I'm not able to reproduce the first issue - @mckealty if you're still experiencing it could you please post more information about your browser version and Shields settings? Just noticed there were two sets of share buttons, this issue refers to the Disqus ones. Those are still appearing, and adding instapundit.com##.share-bar doesn't fix it.

Thanks! Is there something I can add to my rules/filters to get rid of those buttons? Or will it need to be update on your end?

[antonok-edm]

@mckealty It should be fixed once brave/brave-core#14020 is merged; that'll show up in an upcoming Nightly version. I can give you a heads up once it's available.

[mckealty]

@antonok-edm Great, thanks so much for your work!

[antonok-edm]

@mckealty It should be fixed in v1.42.50+; please feel free to follow up if you see any more issues 😃

[antonok-edm]

@mckealty the performance team wanted to see if any additional optimization could be done before enabling this by default, so as of brave/brave-core#14056 you'll have to enable the #brave-adblock-cosmetic-filtering-child-frames flag in brave://flags to use this.

[mckealty]

@antonok-edm Ok sounds good! I would tip you some BAT but for some reason tip buttons have never shown up in my browser. If and when I figure it out I'll send some your way. Thank you for the work you did on this!

[stephendonner]

@antonok-edm looks like we need brave/brave-core#14056 uplifted to 1.42.x in order to be able to test this? I'm not seeing this flag in 1.42.61:

[antonok-edm]

@stephendonner I didn't realize these landed in separate releases, so I've started an uplift. However, you should still be able to test the flag's Enabled behavior without the uplift - before adding the option it was always-on.

[LaurenWags]

Marking as QA/Blocked until brave/brave-core#14196 is uplifted to 1.42.x

[Uni-verse]

Verification PASSED on Samsung GS 21 & Tab S7 using

Brave	1.42.80 Chromium: 104.0.5112.57 (Official Build) (64-bit) 
Revision	212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS	Android 12; Build/SP1A.210812.016

Using STR from #22781 (comment)

• Verified enabling Fanboy Annoyances List in brave://adblock will filter out social elements when visiting https://instapundit.com/513971/#respond
• Verified Feature flag Enable cosmetic filtering in child frames is set to default in brave://flags

Flags/Adblock feature

Flags	Adblock

https://instapundit.com

Filter Enabled	Filter Disabled

[Uni-verse]

Verification PASSED using

Brave	1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (x86_64)
Revision	8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS	macOS Version 12.3.1 (Build 21E258)

Using STR from #22781 (comment)

• Verified enabling Fanboy Annoyances List in brave://adblock will filter out social elements when visiting https://instapundit.com/513971/#respond
• Verified Feature flag Enable cosmetic filtering in child frames is set to default in brave://flags
• Verified that unchecking/disabling Fanboy Annoyances List in brave://adblock will bring back the social elements again.

Filter ON	Filter OFF

Flags	Adblock

[mckealty]

Awesome, thanks so much!

…

On Fri, Jul 1, 2022 at 7:31 PM Anton Lazarev ***@***.***> wrote: @mckealty <https://github.com/mckealty> It should be fixed in v1.42.50+; please feel free to follow up if you see any more issues 😃 — Reply to this email directly, view it on GitHub <#22781 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZZ2CH77URTOBEBXWYQXQMTVR55WHANCNFSM5VUDOMTA> . You are receiving this because you were mentioned.Message ID: ***@***.***>