Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] bitFlyer announcement notification for Japan users #20725

Closed
anthonypkeane opened this issue Jan 27, 2022 · 4 comments
Closed

[Android] bitFlyer announcement notification for Japan users #20725

anthonypkeane opened this issue Jan 27, 2022 · 4 comments
Assignees
Labels
feature/rewards/bitFlyer feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description

@soi-tnk and the team in Japan would like to notify all Android users in Japan that they can now, as of V1.35, use bitFlyer with Brave Rewards.

They would like to send all Japan Android users a system push notification with the following details:

Title: AndroidでもbitFlyer連携開始!
(English: Now you can verify your Rewards wallet with bitFlyer in Brave for Android as well!)

Body: 最大5万円相当BATプレゼントキャンペーン実施中!bitFlyerアカウントと連携して獲得したBATを管理しよう。
(English: Check special BAT present campaign - chance of getting BAT as much as ¥50,000. Let's manage BAT you earn by verifying your Rewards wallet with bitFlyer.)

Timing: 120 min after upgrade or first install
Region: Japan only (new and existing users)

Tapping on the notification should open: http://try.bravesoftware.jp/brave_20220121-1/

This notification should only be scheduled once for the given release and should not be scheduled for subsequent releases. (i.e. if this notification is released into 1.36, the notification should not be rescheduled again in 1.37 or 1.38 etc)

@anthonypkeane anthonypkeane added feature/rewards OS/Android Fixes related to Android browser functionality labels Jan 27, 2022
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 27, 2022
@Miyayes Miyayes changed the title bitFlyer announcement notification for Japan users [Android] bitFlyer announcement notification for Japan users Jan 27, 2022
@anthonypkeane
Copy link
Author

@kjozwiak
Copy link
Member

kjozwiak commented Feb 16, 2022

Some quick notes for @brave/legacy_qa. I went through the clean install cases via brave/brave-core#12268 (comment). However, we'll need to double check the following:

Because we used a one off build that @deeppandya created, upgrading didn't work due to signature issues, hence receiving a "Something went wrong." error message when attempting to upgrade. So once we get the 1.35.101 RC, we'll need to run through the above and make sure that the clean install cases are still working.

@kjozwiak kjozwiak added this to the 1.35.x - Release #3 milestone Feb 16, 2022
@kjozwiak
Copy link
Member

Closing as brave/brave-core#12268 was merged into 1.35.x

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 12 using 1.35.103 Chromium: 98.0.4758.102

Non-Japan (using Canada)

Clean Install (using 1.35.103 Chromium: 98.0.4758.102)

  • ensured that the BitFlyer notification being displayed on a clean install on first launch
  • ensured that the BitFlyer notification isn't being displayed after 2hrs
  • ensured that the BitFlyer notification isn't being displayed after 3hrs
  • ensured that the BitFlyer notification isn't being displayed after 4hrs
  • ensured that the BitFlyer notification isn't being displayed after 1 day
  • ensured that the BitFlyer notification isn't being displayed after 2 days
  • ensured that the BitFlyer notification isn't being displayed after 3 days
  • ensured that the BitFlyer notification isn't being displayed after 4 days

Upgrade (using 1.35.101 Chromium: 98.0.4759.87 --> 1.35.103 Chromium: 98.0.4758.102)

  • ensured that the BitFlyer notification isn't displayed after upgrading to 1.35.103 Chromium: 98.0.4758.102
  • ensured that the BitFlyer notification isn't being displayed after 2hrs
  • ensured that the BitFlyer notification isn't being displayed after 3hrs
  • ensured that the BitFlyer notification isn't being displayed after 4hrs
  • ensured that the BitFlyer notification isn't being displayed after 1 day
  • ensured that the BitFlyer notification isn't being displayed after 2 days
  • ensured that the BitFlyer notification isn't being displayed after 3 days
  • ensured that the BitFlyer notification isn't being displayed after 4 days

Non-Japan (using Canada)

Clean Install (using 1.35.103 Chromium: 98.0.4758.102)

  • ensured that the BitFlyer notification isn't being displayed on a clean install on first launch
  • ensured that the notification appears after 2hrs (example below)
  • ensured that tapping on the BitFlyer notification opens https://brave.com/ja/bitflyer-on-android/
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved time ~3hrs ahead)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved time ~4hrs ahead)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 1)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 2)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 4)
Example Example
Screenshot_20220216-230439 Screenshot_20220216-230536

Upgrade (using 1.35.101 Chromium: 98.0.4759.87 --> 1.35.103 Chromium: 98.0.4758.102)

  • ensured that the BitFlyer notification isn't displayed after upgrading to 1.35.103 Chromium: 98.0.4758.102
  • ensured that the notification appears after 2hrs (example below)
  • ensured that tapping on the BitFlyer notification opens https://brave.com/ja/bitflyer-on-android/
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved time ~3hrs ahead)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved time ~4hrs ahead)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 1)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 2)
  • ensured that the BitFlyer notification doesn't appear once it's been displayed once (moved date by 4)
Example Example
Screenshot_20220216-173113 Screenshot_20220216-173148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards/bitFlyer feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants