Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository in rpm release are broken via cron.daily #1967

Closed
bdekany opened this issue Nov 2, 2018 · 3 comments
Closed

Repository in rpm release are broken via cron.daily #1967

bdekany opened this issue Nov 2, 2018 · 3 comments

Comments

@bdekany
Copy link

bdekany commented Nov 2, 2018

Description

Everyday the repo URL is altered which broke brave update and whole rpm system update
RPM release ship /etc/cron.daily/brave-browser which update brave-browser.repo to link to hhtp://dl.google.com

The variable REPOCONFIG in /etc/cron.daily/brave-browser need to be updated to official brave repo.

Steps to Reproduce

  1. Install brave-browser via rpm-release repository
  2. Wait 1 day
  3. Update system/brave-browser

Actual result:

sudo (zypper|yum|urpmi) up brave-browser

Retrieving repository 'brave-browser' metadata [error]
Repository 'brave-browser' is invalid.
[brave-browser|http://dl.google.com/linux/brave-browser/rpm/stable/x86_64] Valid metadata not found at specified URL
Please check if the URIs defined for this repository are pointing to a valid repository.
Warning: Skipping repository 'brave-browser' because of the above error.
Some of the repositories have not been refreshed because of an error.

Reproduces how often:

Everyday (see /etc/cron.daily/brave-browser)

Brave version (brave://version info)

Brave	0.55.20 Chromium: 70.0.3538.67 (Build officiel) (64 bits)
Révision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
Système d'exploitation	Linux

Reproducible on current release:

  • Reproducible on brave-browser release
  • didn't try dev/beta

Additional Information

Open question: does a privacy oriented browser should alter the distro repo without user consent?
The update_bad_repo func in /etc/cron.daily/brave-browser should be controled via /etc/default/brave-browser

@tneo
Copy link

tneo commented Nov 2, 2018

On openSUSE exists the same problem: see my ticket. Seems like that the repo is not correctly set-up.

@srirambv
Copy link
Contributor

srirambv commented Nov 2, 2018

This could be a dupe of #1084 regarding the wrong repo list being added automatically.

@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@fmarier fmarier self-assigned this Jan 21, 2019
@fmarier fmarier modified the milestones: 1.x Backlog, 0.62.x - Nightly Feb 1, 2019
fmarier added a commit to fmarier/brave-core that referenced this issue Feb 2, 2019
This disables the cronjob that gets installed by the RPM and DEB packages in
order to forcefully add (or re-add) the Google Chrome package repository and
signing key.

This fixes brave/brave-browser#1084 and fixes brave/brave-browser#1967.
@srirambv
Copy link
Contributor

srirambv commented Apr 3, 2019

Verification passed on OpenSuse Leap 15.0

Brave 0.63.29 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants