Ads will not be served for campaign with more than one state geotarget #19050
Assignees
Labels
bug
feature/ads
OS/Desktop
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA/Test-Plan-Specified
QA/Yes
regression
release-notes/exclude
Milestone
Comments
Merged
24 tasks
tmancey
added
the
priority/P1
Merged
24 tasks
btlechowski
added
the
QA/In-Progress
|
Verification passed on
untargeted - 2 states - different creatives - US-OR only1st ad on US-OR 2nd ad US-OR 3rd ad US-OR untargeted - 2 states - different creatives - US-OR into US-CA after round robin1st ad on US-OR 2nd ad on US-OR 3rd US-OR after round robin 4th ad US-CA: 5th ad US-CA 6th ad US-CA untargeted - 2 states - different creatives - US-OR into US-CA before round robin1st ad on US-OR 2nd US-CA 3rd US-OR 4th on US-CA 5th on US-OR 6th us US-CA parent-child - 2 states - different creatives - US-OR into US-CA before round robin
1st ad on US-OR
```
[9761:9761:1030/084436.820777:VERBOSE1:eligible_ad_notifications.cc(88)] Get eligible ads for parent-child segments:
[9761:9761:1030/084436.820857:VERBOSE1:eligible_ad_notifications.cc(90)] technology & computing-software
[9761:9761:1030/084436.820920:VERBOSE1:eligible_ad_notifications.cc(90)] technology & computing-technology & computing
[9761:9761:1030/084436.821026:VERBOSE1:eligible_ad_notifications.cc(90)] business-business
[9761:9761:1030/084436.823801:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[9761:9761:1030/084436.824070:VERBOSE1:ad_notification_serving.cc(122)] Found 2 eligible ads
[9761:9761:1030/084436.824135:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
uuid: 42b661f9-8069-4198-9af9-8bbb80f012cd
creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
segment: technology & computing-software
title: Ad AAA
body: Ad AAA
targetUrl: https://youtube.com
```
2nd ad on US-CA 3rd ad on US-OR 4th ad US-CA parent - 2 states - different creatives - US-OR into US-CA after round robin1st ad on US-OR 2nd ad on US-OR 3rd on US-OR after round robin 4th on US-CA 5th on US-CA 6th |
btlechowski
added
QA Pass-Linux
and removed
QA/In-Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up to #18748.
If there are more that one state geotarget, the ads will not be shown.
Example:
Important: This is a regression in 1.31.x and 1.32.x
Steps to Reproduce
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://no-thanks.invalid --enable-features="CustomAdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled"Actual result:
Ad is not served
Expected result:
Ad is served
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
cc @brave/legacy_qa @rebron @jsecretan @tmancey
The text was updated successfully, but these errors were encountered: