Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced delivery of Brave ads campaigns with subdivision targeting #18748

Closed
tmancey opened this issue Oct 13, 2021 · 1 comment · Fixed by brave/brave-core#10551
Closed

Reduced delivery of Brave ads campaigns with subdivision targeting #18748

tmancey opened this issue Oct 13, 2021 · 1 comment · Fixed by brave/brave-core#10551
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.31.x - Release #2

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 13, 2021 •
edited
Loading

Description

Reduced delivery of Brave ads campaigns with subdivision targeting

Steps to Reproduce

  1. View ads (with state level targeting, catalog must also have ads for other US states)

Actual result:

Ads/advertisers do not round robin if a campaign has state level targeting for another state

Expected result:

Ads/advertisers should round robin if a campaign has state level targeting for another state

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Round robin does not work if ads are excluded due to state level targeting. This will also help with high CPU usage as a user will not be stuck in the state where there are no ads. And if they are, follow up performance fixes are being worked on
@tmancey tmancey added needs-investigation A bug not 100% confirmed/fixed feature/ads OS/Desktop labels Oct 13, 2021
@tmancey tmancey self-assigned this Oct 13, 2021
@tmancey tmancey added bug QA/Yes release-notes/exclude priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed needs-investigation A bug not 100% confirmed/fixed labels Oct 15, 2021
This was referenced Oct 15, 2021
Closed
Merged
@tmancey tmancey added this to the 1.33.x - Nightly milestone Oct 19, 2021
@jsecretan jsecretan added the OS/iOS Fixes related to iOS browser functionality label Oct 19, 2021
This was referenced Oct 20, 2021
Merged
Merged
@btlechowski btlechowski mentioned this issue Oct 28, 2021
Closed
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 29, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS

Full test run on 1.33.x can be found in brave/brave-core#10551 (comment)
Sanity check was made on 1.31.x due to lack of time.

1st ad US-CA

[15283:15283:1030/162551.680564:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[15283:15283:1030/162551.682966:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 excluded as not within the targeted subdivision
[15283:15283:1030/162551.690966:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[15283:15283:1030/162551.691224:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[15283:15283:1030/162551.691271:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: 21aca138-d927-4c57-99c9-0bb3b8700ca7
  creativeInstanceId: d23b41d2-74b5-42b3-8169-5017984731ee
  creativeSetId: e76b526f-79dd-4111-8778-ca7b194c66fa
  campaignId: dd64fb34-f683-45b3-b2ba-dd6e1715f48f
  advertiserId: dd3d043b-51ca-4c6c-8ddd-16afa165ce1b
  segment: untargeted
  title: Ad BBB
  body: Ad BBB
  targetUrl: https://www.brave.com/FOO

2nd ad US-OR

[16031:16031:1030/173151.784170:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[16031:16031:1030/173151.788820:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId e76b526f-79dd-4111-8778-ca7b194c66fa excluded as not within the targeted subdivision
[16031:16031:1030/173151.789049:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[16031:16031:1030/173151.789878:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[16031:16031:1030/173151.789934:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: dbeb8c06-5eac-42f0-8d81-07f1bede838c
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad AAA
  body: Ad AAA
  targetUrl: https://youtube.com

3rd ad US-CA after round robin

[16400:16400:1030/183552.934650:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[16400:16400:1030/183552.938110:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 excluded as not within the targeted subdivision
[16400:16400:1030/183552.942487:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[16400:16400:1030/183552.942537:VERBOSE1:client.cc(487)] Resetting seen ad_notification advertisers
[16400:16400:1030/183552.942929:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[16400:16400:1030/183552.943020:VERBOSE1:client.cc(451)] Resetting seen ad_notifications
[16400:16400:1030/183552.943094:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[16400:16400:1030/183552.943229:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[16400:16400:1030/183552.943250:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: 9b5cfe53-a74d-4cd4-bf20-0f9cdcb9bf3e
  creativeInstanceId: d23b41d2-74b5-42b3-8169-5017984731ee
  creativeSetId: e76b526f-79dd-4111-8778-ca7b194c66fa
  campaignId: dd64fb34-f683-45b3-b2ba-dd6e1715f48f
  advertiserId: dd3d043b-51ca-4c6c-8ddd-16afa165ce1b
  segment: untargeted
  title: Ad BBB
  body: Ad BBB
  targetUrl: https://www.brave.com/FOO

4th US-OR after round robin

[16771:16771:1030/193809.117671:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[16771:16771:1030/193809.123078:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId e76b526f-79dd-4111-8778-ca7b194c66fa excluded as not within the targeted subdivision
[16771:16771:1030/193809.125924:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[16771:16771:1030/193809.126265:VERBOSE1:client.cc(487)] Resetting seen ad_notification advertisers
[16771:16771:1030/193809.126939:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[16771:16771:1030/193809.127277:VERBOSE1:client.cc(451)] Resetting seen ad_notifications
[16771:16771:1030/193809.127472:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[16771:16771:1030/193809.127754:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[16771:16771:1030/193809.127890:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: 50db6963-20a8-446c-b35c-9cfa7f54bd9d
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad AAA
  body: Ad AAA
  targetUrl: https://youtube.com

5th US-CA

[17482:17482:1030/204233.667485:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[17482:17482:1030/204233.669389:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 excluded as not within the targeted subdivision
[17482:17482:1030/204233.671448:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[17482:17482:1030/204233.671612:VERBOSE1:client.cc(487)] Resetting seen ad_notification advertisers
[17482:17482:1030/204233.671794:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[17482:17482:1030/204233.672465:VERBOSE1:client.cc(451)] Resetting seen ad_notifications
[17482:17482:1030/204233.672739:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[17482:17482:1030/204233.673039:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[17482:17482:1030/204233.674380:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: b000bec5-b3c6-4057-8fb7-3cc11d1a74b0
  creativeInstanceId: d23b41d2-74b5-42b3-8169-5017984731ee
  creativeSetId: e76b526f-79dd-4111-8778-ca7b194c66fa
  campaignId: dd64fb34-f683-45b3-b2ba-dd6e1715f48f
  advertiserId: dd3d043b-51ca-4c6c-8ddd-16afa165ce1b
  segment: untargeted
  title: Ad BBB
  body: Ad BBB
  targetUrl: https://www.brave.com/FOO

6th US-OR

[17835:17835:1030/214521.377934:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligible ads for untargeted segment
[17835:17835:1030/214521.385237:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId e76b526f-79dd-4111-8778-ca7b194c66fa excluded as not within the targeted subdivision
[17835:17835:1030/214521.385429:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[17835:17835:1030/214521.385573:VERBOSE1:client.cc(487)] Resetting seen ad_notification advertisers
[17835:17835:1030/214521.385818:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[17835:17835:1030/214521.385942:VERBOSE1:client.cc(451)] Resetting seen ad_notifications
[17835:17835:1030/214521.386077:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[17835:17835:1030/214521.386366:VERBOSE1:ad_notification_serving.cc(122)] Found 1 eligible ads
[17835:17835:1030/214521.386481:VERBOSE1:ad_notification_serving.cc(218)] Serving ad notification:
  uuid: 4070f499-e227-4c9e-a4f2-793dfe98c458
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad AAA
  body: Ad AAA
  targetUrl: https://youtube.com

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 29, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.31.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fixes reduced delivery of Brave ads campaigns with subdivision targeting brave/brave-core
4 participants
@jsecretan @tmancey @kjozwiak @btlechowski