Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding recurring date within the tip table under brave://rewards #1834

Closed
kjozwiak opened this issue Oct 25, 2018 · 5 comments · Fixed by brave/brave-core#1412
Closed

adding recurring date within the tip table under brave://rewards #1834

kjozwiak opened this issue Oct 25, 2018 · 5 comments · Fixed by brave/brave-core#1412

Comments

@kjozwiak
Copy link
Member

Description

We should display the recurring date within the Tip table under brave://rewards. Once a user sets a recurring tip and forgets the date, there's no visible way to check via the current UI.

Steps to Reproduce

  1. launch the most recent version of brave (0.55.20 Chromium: 70.0.3538.67 in this case)
  2. enable rewards via brave://rewards & accept a grant
  3. visit a any website and click on the BAT icon under the URL
  4. click on Send tip..
  5. select an amount and enable Make this monthly and click on Set monthly Tip
  6. visit brave://rewards and you'll see the entry but there's no visible recurring date

Actual result:

screen shot 2018-10-25 at 3 04 18 am

Expected result:

We should display the recurring date within the table. Once a user sets a recurring tip and forgets the date, there's no visible way to check via the current UI.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under both dev and beta as well.

Additional Information

CCing @jenn-rhim

@NejcZdovc
Copy link
Contributor

@kjozwiak recurring date is the same as auto contribute date in table above

@NejcZdovc NejcZdovc removed this from the 0.56.x - Beta milestone Oct 25, 2018
@kjozwiak kjozwiak added this to the 1.0 milestone Oct 25, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@NejcZdovc
Copy link
Contributor

cc @davidtemkin @jenn-rhim

@NejcZdovc
Copy link
Contributor

ping @davidtemkin @mandar-brave should we implement this or close it?

@davidtemkin
Copy link

Let's do it. Add a line to the Tips panel, as follows:

"Monthly tips will next be sent" followed by the next contribution date.

The formatting should match the line in the A-C panel ("next contribution date").

NOTE : This line should only appear if the user has established one or more monthly tips. In the event that there are no active monthly tips, the line should not appear.

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jan 20, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 8, 2019

Verified passed with

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified test plan from Adds recurring date to donations box brave-core#1412
  • Verified if there are no recurring tips, the contribution line is not displayed:
    screen shot 2019-02-08 at 5 43 44 pm
    screen shot 2019-02-08 at 5 44 55 pm
  • Verified when there is at least one recurring tip the contribution line is displayed:
    screen shot 2019-02-08 at 5 45 10 pm
  • Verified that if only one recurring tip is listed and you remove it, the contribution date line is removed from view
  • Verified that once monthly recurring tips contribute, the date in this panel is updated (note, screenshots below are from a different profile than the one used above that's why the 'Total tips this month' value is different):
    screen shot 2019-02-08 at 5 50 09 pm
    screen shot 2019-02-08 at 5 51 40 pm
  • Logged follow up issue for text Contribution date text on Tips panel #3287

Verification passed on

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants