Unable to exit Speedreader mode/disable Speedreader

[stephendonner]

Description

Unable to exit Speedreader mode/disable Speedreader

Steps to Reproduce

1. new profile
2. launch Brave
3. load https://www.reuters.com/technology/cryptocurrencies-selloff-widens-bitcoin-down-nearly-4-ether-6-2021-09-07/
4. click on the Reader Mode icon in the URL bar
5. click to enable Speedreader
6. now, click on the Speedreader icon again

Expected:

The page exits Speedreader/Reader Mode, and returns to “full” HTML mode rendering

Actual:

Even though it appears I’ve toggled reader mode to Off/Disabled, it persists for this tab

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.31.27 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	macOS Version 11.5.2 (Build 20G95)

/cc @keur

[kkuehlz]

Added release-notes/exclude since this bug hasn't made it out of nightly.

[kkuehlz]

Test Plan

Ensure the per-site toggle works as expected. Thanks @stephendonner !

[stephendonner]

Verified PASSED using

Brave	1.31.44 Chromium: 94.0.4606.41 (Official Build) nightly (x86_64)
Revision	333e85df3c9b656b518b5f1add5ff246365b6c24-refs/branch-heads/4606@{#845}
OS	macOS Version 11.6 (Build 20G165)

Steps:

1. load https://www.reuters.com/technology/cryptocurrencies-selloff-widens-bitcoin-down-nearly-4-ether-6-2021-09-07/
2. click on the Reader Mode icon in the URL bar
3. click to enable Speedreader
4. now, click on the Speedreader icon again

Confirmed I was able to toggle Speedreader on/off at will

example	example

---

Verification passed on

Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

1. load https://www.reuters.com/technology/cryptocurrencies-selloff-widens-bitcoin-down-nearly-4-ether-6-2021-09-07/
2. click on the Reader Mode icon in the URL bar
3. click to enable Speedreader
4. now, click on the Speedreader icon again

Confirmed I was able to toggle Speedreader on/off at will

• Encountered the issue Unable to exit reader mode when Speedreader is disabled #18242 (comment)
  

---

Verified PASSED using

Brave	1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	Linux

Steps:

1. load https://www.reuters.com/technology/cryptocurrencies-selloff-widens-bitcoin-down-nearly-4-ether-6-2021-09-07/
2. click on the Reader Mode icon in the URL bar
3. click to enable Speedreader
4. now, click on the Speedreader icon again

Confirmed I was able to toggle Speedreader on/off at will

example	example

[Tonev]

@keur @stephendonner

Sorry for disturbing you, folks, I just wanted to ask if the fix for this is available in:

Brave	1.31.51 Chromium: 94.0.4606.50 (Official Build) nightly (64-bit)
Revision	0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS	Windows 7 Service Pack 1 (Build 7601)
JavaScript	V8 9.4.146.16
User Agent	Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.50 Safari/537.36

I can reproduce the bug, described by @stephendonner, so thought I would ask. I'm not aware how Brave Nightly versions are released on macOS, compared to Windows, and it looked like the issue is still present in Brave Nightly.

What I'm experiencing might be a different bug, because I can enter/exit reader mode at will when the Speedreader feature is enabled via brave://settings/appearance.

Here is what I'm experiencing:

1. Ensure Speedreader is disabled via brave://settings/appearance.
2. Open https://www.reuters.com/technology/cryptocurrencies-selloff-widens-bitcoin-down-nearly-4-ether-6-2021-09-07/.
3. Click on the reader mode icon in the address bar.

Actual result:

The article goes into a reader mode. I can't exit the reader mode upon clicking on the reader mode icon in the address bar.

Expected result:

The article goes into a reader mode. Clicking on the reader mode icon in the address bar should exit the reader mode.

This issue is not present in the current Brave release, neither in Brave Beta.

P.S Let me know if you would like me to open a new Github issue for the issue I described, because I'm not sure if the issue is related to Speedreader as the feature is disabled via brave://settings/appearance.

[stephendonner]

@Tonev thanks; I think this is a related, but distinct, issue (which I still should've found while testing this issue's fix). Please file a new issue? Thanks!