-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet_active to stats usage ping #17059
Labels
feature/ethereum-remote-client
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Milestone
Comments
kkuehlz
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
labels
Jul 21, 2021
kkuehlz
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 21, 2021
24 tasks
kkuehlz
added
priority/P2
A bad problem. We might uplift this to the next planned release.
and removed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Aug 13, 2021
Added p2 because @bbondy asked for this to be uplifted. cc @kjozwiak @stephendonner |
7 tasks
Verification passed on
Scenario 2Step 1: (Daily, Weekly, Monthly)Step 2: (Weekly, monthly)Scenario 3: MonthlyVerification passed on
Scenario 2Step 1: (Daily, Weekly, Monthly)Step 2: (Weekly, monthly)Scenario 3: MonthlyVerification passed on
Scenario 2Step 1: (Daily, Weekly, Monthly)Step 2: (Weekly, monthly)Scenario 3: Monthly |
srirambv
added
feature/ethereum-remote-client
and removed
feature/web3/wallet
Integrating Ethereum+ wallet support
labels
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ethereum-remote-client
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Will include data for
wallet_daily
,wallet_weekly
, andwallet_monthly
. To reduce the number of query parameters on the server-side, we will send it up as a bitstring.Test Plan
Prerequisites
Scenario 1
Without enabling brave crypto wallets, close browser, move system time forward one day, open browser. Stats ping should be the same with a new parameter walletActive=0
Scenario 2
Step 1: Daily, weekly, monthly
In this order: (1) Enable brave crypto wallets, (2) close browser, (3) move systems time forward by one day (ensure the month and week don’t change), (4) restart browser and look for stats ping. Stats ping should include walletActive=7 on the following stats ping.
Step 2: Weekly, monthly
Do not use the crypto wallet. Move system time forward an arbitrary number of days within the same week (greater than 1 day from). Restart browser. Stats ping should include walletActive=6.
Step 3: Monthly
Do not use the crypto wallet. Move system time forward an arbitrary number of days within the same month (greater than 1 week). Restart browser. Stats ping should include walletActive=4.
Step 4: Re-enabling
Use the crypto wallet. Close browser. Move system time forward by a day. Restart browser. Stats ping should include walletActive=7.
The text was updated successfully, but these errors were encountered: