Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet_active to stats usage ping #17059

Closed
kkuehlz opened this issue Jul 21, 2021 · 2 comments · Fixed by brave/brave-core#9506
Closed

Add wallet_active to stats usage ping #17059

kkuehlz opened this issue Jul 21, 2021 · 2 comments · Fixed by brave/brave-core#9506

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 21, 2021

Will include data for wallet_daily, wallet_weekly, and wallet_monthly. To reduce the number of query parameters on the server-side, we will send it up as a bitstring.

Test Plan

Prerequisites

  1. A clean browser profile
  2. A system whereby it is possible to modify the system clock
  3. Charles proxy, wireshark, or other HTTP sniffing tool

Scenario 1

Without enabling brave crypto wallets, close browser, move system time forward one day, open browser. Stats ping should be the same with a new parameter walletActive=0

Scenario 2

Step 1: Daily, weekly, monthly

In this order: (1) Enable brave crypto wallets, (2) close browser, (3) move systems time forward by one day (ensure the month and week don’t change), (4) restart browser and look for stats ping. Stats ping should include walletActive=7 on the following stats ping.

Step 2: Weekly, monthly

Do not use the crypto wallet. Move system time forward an arbitrary number of days within the same week (greater than 1 day from). Restart browser. Stats ping should include walletActive=6.

Step 3: Monthly

Do not use the crypto wallet. Move system time forward an arbitrary number of days within the same month (greater than 1 week). Restart browser. Stats ping should include walletActive=4.

Step 4: Re-enabling

Use the crypto wallet. Close browser. Move system time forward by a day. Restart browser. Stats ping should include walletActive=7.

@kkuehlz kkuehlz self-assigned this Jul 21, 2021
@kkuehlz kkuehlz added OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jul 21, 2021
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 21, 2021
@kkuehlz kkuehlz added this to the 1.30.x - Nightly milestone Aug 11, 2021
@kkuehlz kkuehlz added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 13, 2021
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Aug 13, 2021

Added p2 because @bbondy asked for this to be uplifted. cc @kjozwiak @stephendonner

@stephendonner stephendonner added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 16, 2021
@kjozwiak kjozwiak removed the OS/Android Fixes related to Android browser functionality label Aug 23, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Linux
Scenario 1
  • Verified without enabling Crypto Wallet, stats ping shows new parameter &walletActive=0
    image
Scenario 2
Step 1: (Daily, Weekly, Monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to the next date within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image
Step 2: (Weekly, monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to a random day within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=6
    image
Scenario 3: Monthly
  • Did not use crypto wallet, closed browser
  • Move device date ahead to a future date within the same month
  • Restart the browser and verified stats ping now includes &walletActivie=4
    image
Scenario 4: Re-enabling
  • Logged into crypto wallet and added a new account and closed browser
  • Move device date ahead to the next date
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image

Verification passed on

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Windows 10 OS Version 2009 (Build 19043.1110
Scenario 1
  • Verified without enabling Crypto Wallet, stats ping shows new parameter &walletActive=0
    image
Scenario 2
Step 1: (Daily, Weekly, Monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to the next date within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image
Step 2: (Weekly, monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to a random day within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=6
    image
Scenario 3: Monthly
  • Did not use crypto wallet, closed browser
  • Move device date ahead to a future date within the same month
  • Restart the browser and verified stats ping now includes &walletActivie=4
    image
Scenario 4: Re-enabling
  • Logged into crypto wallet and added a new account and closed browser
  • Move device date ahead to the next date
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image

Verification passed on

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)
Scenario 1
  • Verified without enabling Crypto Wallet, stats ping shows new parameter &walletActive=0
    image
Scenario 2
Step 1: (Daily, Weekly, Monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to the next date within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image
Step 2: (Weekly, monthly)
  • Enabled crypto wallet, closed browser
  • Move device date ahead to a random day within the same week/month
  • Restart the browser and verified stats ping now includes &walletActivie=6
    image
Scenario 3: Monthly
  • Did not use crypto wallet, closed browser
  • Move device date ahead to a future date within the same month
  • Restart the browser and verified stats ping now includes &walletActivie=4
    image
Scenario 4: Re-enabling
  • Logged into crypto wallet and added a new account and closed browser
  • Move device date ahead to the next date
  • Restart the browser and verified stats ping now includes &walletActivie=7
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants