Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom ad notifications do not respect dark mode on Android #16350

Closed
GeetaSarvadnya opened this issue Jun 10, 2021 · 2 comments · Fixed by brave/brave-core#9343
Closed

Custom ad notifications do not respect dark mode on Android #16350

GeetaSarvadnya opened this issue Jun 10, 2021 · 2 comments · Fixed by brave/brave-core#9343
Assignees
@aseren
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.28.x - Release

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 10, 2021 •
edited
Loading

Description

Found while testing #14810
Custom AD notifications don't respect dark mode

Steps to reproduce

  1. Clean profile 1.26.56
  2. Enable rewards
  3. Set the Dark mode/theme via settings->appearance
  4. View a custom AD

Actual result

System Default
Screenshot_20210610-222911_Brave - Beta

Dark Mode
Screenshot_20210610-225018_Brave - Beta

Expected result

Custom ads notification should respect dark mode

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): Android Tab
  • Device type (Phone, Tablet, Phablet): Android Tab 10
  • Android version: 10

Brave version

1.26.56

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @tmancey
This was referenced Jun 10, 2021
Closed
Closed
@tmancey tmancey changed the title Custom AD notifications don't respect dark mode Custom ad notifications do not respect dark mode on Android Jun 10, 2021
@btlechowski
Copy link

Similar issue on Linux: #16234

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 14, 2021
Closed
@aseren aseren self-assigned this Jul 6, 2021
@aseren aseren mentioned this issue Jul 6, 2021
Merged
24 tasks
aseren added a commit to brave/brave-core that referenced this issue Jul 7, 2021
@aseren
Add dark mode layout for custom ads popup on android.
8a42e88 
Also added functionality to switch between dark/light modes on theme
setting change.
fix brave/brave-browser#16350
aseren added a commit to brave/brave-core that referenced this issue Jul 9, 2021
@aseren
Add dark mode layout for custom ads popup on android.
07f1a8a 
Also added functionality to switch between dark/light modes on theme
setting change.
fix brave/brave-browser#16350
@tmancey tmancey added this to the 1.28.x - Nightly milestone Jul 12, 2021
@srirambv
Copy link
Contributor

srirambv commented Aug 3, 2021

Verification passed on Oppo R5 with Android 11 running 1.28.99 x64 Beta Build

  • Verified custom ad notification follow device/app theme
Light Dark
image image

Verification passed on Samsung Tab A with Android 10 running 1.28.99 x64 Beta Build

  • Verified custom ad notification follow device/app theme
Light Dark
image image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Add dark mode layout for custom ads popup on android. brave/brave-core
5 participants
@tmancey @srirambv @btlechowski @GeetaSarvadnya @aseren