Spin ball after clicking direct donations or auto contributing

[NejcZdovc]

Description

When you click on send tip you get spinner for a few seconds

Steps to Reproduce

1. enable rewards
2. claim grant
3. go to site and click on BAT logo, donate now, select amount and click send tip

Actual result:

Spinner for few second after successful send

Expected result:

No spinner

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
• Does it reproduce on browser-laptop?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

[LaurenWags]

During Auto-Contribute I got the beachball for about 2 minutes using

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

[srirambv]

@LaurenWags this specific to mac correct?

[LaurenWags]

@srirambv beachball is specific to mac - but I'm not sure if you'll see Brave frozen, or some other ill side effect on Win or Linux during this time.

[srirambv]

I didn't see Brave freeze on Windows/Linux. Added macOS label

[btlechowski]

Brave froze for me on Windows 7 for around 10 seconds when auto-contributing 5 sites.
It also freezes for couple of seconds after tipping.

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Windows 7 x64

[kjozwiak]

Asked @LaurenWags to move this into this milestone as this needs a decision from @davidtemkin and others. QA noticed that when a contribution or tipping occurs, the browser tends to become unstable for a few seconds. This might get a LOT worse if someone has a huge list under auto-contribute.

Only reason we might move this out is we might have some time before people start contributing to get a hotfix out. I wanted everyone to be aware that this exists.

@mandar-brave ran into the same issue and noticed the freezing when he was demoing to QA.

CCing @bbondy @davidtemkin @NejcZdovc @rebron

[kjozwiak]

Still an issue with the following build (RC2):

Brave	0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}

[kjozwiak]

@NejcZdovc mentioned that he'll try landing this tomorrow. Going to move it back into 0.55.x. I think we really need to fix this. Anytime anyone sends a tip or an auto-contribution is triggered, the entire browser becomes unresponsive. I've seen b-c become unresponsive for at least 8-10 seconds at times. When you send a tip, b-c becomes responsive for about ~3seconds or so.

[srirambv]

Verification Passed on

Brave	0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Mac OS X

Verification passed on

Brave	0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Windows 7 x64