Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAT not userdraining: Browser should check if wallet is backend-verified before sending tokens #15998

Closed
Miyayes opened this issue May 20, 2021 · 3 comments
Closed

BAT not userdraining: Browser should check if wallet is backend-verified before sending tokens #15998

Miyayes opened this issue May 20, 2021 · 3 comments
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-investigation A bug not 100% confirmed/fixed OS/Desktop

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 20, 2021 •
edited
Loading

Description

Browser should perform a GET /v3/wallet/<payment id> to figure out if the wallet is fully “backend verified”. If not, then perform linking flow prior to sending tokens. (Or, implement equivalent solution.)

Based on investigation, this is the leading reasons why userdrains are not occurring. This should substantially increase robustness of the userdrain process.

@husobee for details.
@Miyayes Miyayes added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop labels May 20, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jun 9, 2021

Not clear whether this addresses an issue that is different than #15390. In other words, it's not clear whether the only time a user will be in the state above is if they are in a semi-verified state: #15390

@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 9, 2021
@bsclifton bsclifton mentioned this issue Jun 9, 2021
Closed
@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 10, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jun 10, 2021 •
edited
Loading

After some engineering discussion, the problem may run deeper than this, and it's not totally clear that this would actually fix the problem for some users. Engineers are evaluating a more root solution related to #15390. To be clear, #15390 is not simply a function of exceeding the linking limit. So current idea is to solve #15390, which we hope will fix a lot of the underlying foundation. This issue (#15998) can be an additional redundancy on top of a root fix of #15390.

@Miyayes Miyayes added needs-investigation A bug not 100% confirmed/fixed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 11, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 10, 2021

I think this has been superseded. Can open a new issue in future if needed.

@Miyayes Miyayes closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-investigation A bug not 100% confirmed/fixed OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Miyayes