Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token list for Crypto Wallets extension #15688

Closed
bbondy opened this issue May 7, 2021 · 1 comment · Fixed by brave/ethereum-remote-client#236
Closed

Update token list for Crypto Wallets extension #15688

bbondy opened this issue May 7, 2021 · 1 comment · Fixed by brave/ethereum-remote-client#236
Assignees
@onyb
Labels
feature/ethereum-remote-client OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
Ethereum Remote C...

Comments

@bbondy
Copy link
Member

bbondy commented May 7, 2021

Update token list dependency for brave/ethereum-remote-client.

I noticed we are missing some tokens that MetaMask has like Aave a-tokens.
onyb added a commit to onyb/ethereum-remote-client that referenced this issue May 7, 2021
@onyb
chore: update ERC-20 token list
8502c9f 
The package eth-contract-metadata has been deprecated, and replaced
with @metamask/contract-metadata.

Fixes brave/brave-browser#15688.
onyb added a commit to onyb/ethereum-remote-client that referenced this issue May 7, 2021
@onyb
chore: update ERC-20 token list
f75e4de 
The package eth-contract-metadata has been deprecated, and replaced
with @metamask/contract-metadata.

Fixes brave/brave-browser#15688.
@onyb onyb mentioned this issue May 7, 2021
Merged
onyb added a commit to onyb/ethereum-remote-client that referenced this issue May 9, 2021
@onyb
chore: update ERC-20 token list
1276cf4 
The package eth-contract-metadata has been deprecated, and replaced
with @metamask/contract-metadata.

Fixes brave/brave-browser#15688.
@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/include labels May 14, 2021
@bbondy bbondy added this to the Ethereum Remote Client 1.0.29 milestone May 14, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.26.64 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 10.15.7 (Build 19H114)
Component 1.0.30 Dev
  • Verified AAVE wrapped tokens exist in the Assets list. Ex: aDAI, aWETH, aTUSD
image image

  • Verified token upgrades are available. Ex: REPv2 and REP both listed in the token list.
    image

  • Verified REN token formerly known as "Republic Protocol" is renamed to "Republic Token".
    image

  • Verified deprecated token EOS is longer available in the token list
    image

  • Verified FKX contract address is changed to 0x16484d73Ac08d2355F466d448D2b79D2039F6EBB

FKX.Contract.Address.-.macOS.mov

Verification passed on

Brave 1.27.69 Chromium: 91.0.4472.106 (Official Build) beta (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Windows 10 OS Version 2009 (Build 19042.1052)
Component 1.0.30 Dev
  • Verified AAVE wrapped tokens exist in the Assets list. Ex: aDAI, aWETH, aTUSD
image image

  • Verified token upgrades are available. Ex: REPv2 and REP both listed in the token list.
    image

  • Verified REN token formerly known as "Republic Protocol" is renamed to "Republic Token".
    image

  • Verified deprecated token EOS is longer available in the token list
    image

  • Verified FKX contract address is changed to 0x16484d73Ac08d2355F466d448D2b79D2039F6EBB

FKX.Contract.Address.-.Win.mov

Verification passed on

Brave 1.28.17 Chromium: 91.0.4472.114 (Official Build) nightly (64-bit)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS Linux
Component 1.0.30 Dev
  • Verified AAVE wrapped tokens exist in the Assets list. Ex: aDAI, aWETH, aTUSD
image image

  • Verified token upgrades are available. Ex: REPv2 and REP both listed in the token list.
    image

  • Verified REN token formerly known as "Republic Protocol" is renamed to "Republic Token".
    image

  • Verified deprecated token EOS is longer available in the token list
    image

  • Verified FKX contract address is changed to 0x16484d73Ac08d2355F466d448D2b79D2039F6EBB

FKX.Contract.Address.-.Linux.mp4

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/ethereum-remote-client OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
Ethereum Remote Client 1.0.29
Development

Successfully merging a pull request may close this issue.

Update ERC-20 token list and fix audit errors onyb/ethereum-remote-client
3 participants
@bbondy @onyb @srirambv