Remove chrome-browser-browsing_data-chrome_browsing_data_remover_delegate_factory.cc.patch

[mariospr]

Description

This patch could be removed in favour of a chromium_src override that would define its own version of ChromeBrowsingDataRemoverDelegateFactory::BuildServiceInstanceFor() to simply return an instance of BraveBrowsingDataRemoverDelegate(), instead of patching the original method from upstream (which doesn't do anything else other than returning an instance of ChromeBrowsingDataRemoverDelegate).

Brave version (brave://version info)

Brave 1.24.2 (Chromium 89.0.4389.90)

Miscellaneous Information:

This removal references a patch initially introduced with #8231 (and later modified for #8826) so please use the test plan detailed in brave/brave-core#4624 for QA purposes (i.e. check that things continue to work).

[mariospr]

Closing as per review comments in the associated PR

[stephendonner]

Verified PASSED using testplans from both #8231 and #8826

Brave	1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (x86_64)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	macOS Version 11.2.3 (Build 20D91)

Confirmed that the UI reads Site and Shields Settings in brave://settings/clearBrowserData

Steps:

1. Launched Brave with a new profile
2. Loaded brave.com and changed Cross-site cookies blocked to Cookies blocked via the Shields panel
3. Launched the Clear Browsing data dialog via brave://settings/clearBrowserData
4. Confirmed that Site Settings has 1 Site as a label with the Last hour time range
5. Clicked the Clear data button and checked that the label is now None
6. Loaded brave.com and confirmed that Cross-site cookies blocked is now restored as the default in the Shields settings

example	example	example	example

---

Verification passed on

Brave	1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	Ubuntu 18.04 LTS

Verified test plan from #8231 and #8826

Verification

changed Cross-site cookies blocked to Cookies blocked via the Shields panel

Confirmed that Site Settings has 1 Site as a label with the Last hour time range in brave://settings/clearBrowserData

Confirmed that Site Settings has None as a label with the Last hour time range in brave://settings/clearBrowserData after clearing data

confirmed that Cross-site cookies blocked is now restored as the default in the Shields settings

---

Verification passed on

Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

changed Cross-site cookies blocked to Cookies blocked via the Shields panel

Steps:

1. Launched Brave with a new profile
2. Loaded brave.com and changed Cross-site cookies blocked to Cookies blocked via the Shields panel
3. Launched the Clear Browsing data dialog via brave://settings/clearBrowserData
4. Confirmed that Site Settings has 1 Site as a label with the Last hour time range
5. Clicked the Clear data button and checked that the label is now None
6. Loaded brave.com and confirmed that Cross-site cookies blocked is now restored as the default in the Shields settings