Remove third_party-crashpad-crashpad-client-settings.cc.patch

[mariospr]

Description

This patch could be removed in favour of a chromium_src override redefining the Settings::GetClientID() method into something that uses the original implementation from upstream and simply resets the memory of client_id before returning when needed.

Brave version (brave://version info)

Brave 1.24.2 (Chromium 89.0.4389.90)

Miscellaneous Information:

This removal references a patch initially introduced with #8865

[stephendonner]

Verified PASSED using the testplan from brave/brave-core#8278 with nightly build:

Brave	1.24.29 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision	e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. triggered a crash via brave://crash
2. went to brave://crashes and ensured the crash was sent (crash ID is 4e160000-0c88-1106-0000-000000000000)
3. looked up the crash ID on our backtrace instance
4. found my way to the Debug tab
5. from there, clicked on Attributes
6. checked value of guid

Got:

guid 00000000-0000-0000-0000-000000000000

Example	Example	Example

---

Verified PASSED on Win 10 x64 using the following build:

Brave | 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Cases:

1. triggered a crash via brave://crash & brave://gpucrash
2. went into brave://crashes and sent both crashes as per the following:

* Uploaded crash report ID: | 693f0000-ff38-2d06-0000-000000000000
* Uploaded crash report ID: | 683f0000-ff38-2d06-0000-000000000000

3. looked up the crash ID on BackTrace and ensured that the GUID was blank for the above crashes

Example (brave://crash)	Example (brave://gpucrash)

---

Verification passed on

Brave	1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	Ubuntu 18.04 LTS

Verified crash was uploaded