Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tools / Inspect element window doesn't open on latest brave releases (VERY slow to open) #14721

Closed
shanytc opened this issue Mar 15, 2021 · 29 comments

Comments

@shanytc
Copy link

shanytc commented Mar 15, 2021

Description

On my MacBook Pro (13-inch, 2020),
The latest brave browser releases completely broke the inspect element window. It will no longer open immediately, and if it does, it's after 30 seconds or 1 minute sometimes not at all. When it does open it's unresponsive.

Steps to Reproduce

  1. Install Latest brave releases for OSX
  2. Open any page
  3. right click -> inspect element -> it's not showing / takes around 30secs to 1 minute to open

Actual result:

Opens after 30secs or 1 minute like this: https://ibb.co/HtMLgGg

Expected result:

Should open immediately like this: https://ibb.co/tCBHcMy

Reproduces how often:

100% of the time.

Brave version (brave://version info)

Version 1.21.76

Version/Channel Information:

Version 1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

unresponsive behaviour for developers.

@jowsey
Copy link

jowsey commented Mar 21, 2021

Also get the same issue on 1.24.8 on Windows 10

@shanytc
Copy link
Author

shanytc commented Mar 21, 2021

Also get the same issue on 1.24.8 on Windows 10

Good to know! Seems this is a wide issue.

@rebron rebron added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 23, 2021
@kjozwiak kjozwiak added this to the 1.22.x - Release #2 milestone Mar 23, 2021
@rebron rebron changed the title 🐛 OSX: Inspect element window doesn't open on latest brave releases Inspect element window doesn't open on latest brave releases Mar 23, 2021
@bsclifton bsclifton changed the title Inspect element window doesn't open on latest brave releases Dev tools / Inspect element window doesn't open on latest brave releases Mar 23, 2021
@bsclifton bsclifton changed the title Dev tools / Inspect element window doesn't open on latest brave releases Dev tools / Inspect element window doesn't open on latest brave releases (VERY slow to open) Mar 23, 2021
@bsclifton bsclifton self-assigned this Mar 23, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Mar 23, 2021
…1.22.x"

Fixes brave/brave-browser#14721 for 1.22.x

Problem still in `1.23.x` and `master` branches

Auditor: @darkdh

This reverts commit 27cf5ef, reversing
changes made to e104d7c.
@bsclifton
Copy link
Member

bsclifton commented Mar 23, 2021

Fixed in 1.22.x with brave/brave-core@f20e8ba

This is still a problem in other channels though ☹️ We can probably keep this issue open as a blocker for 1.23

@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2021

As per the above, we reverted the change that caused the issue in 1.22.66. The fix that will address the underlying problem will be done via #14880.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2021

@brave/legacy_qa we'll basically need to make sure that the DevTools is working as expected on a default install. The fix that will address the underlying problem will be done via #14880.

As per @darkdh, this was due to the following:

It is because adblock intercepted requests from devtools, and because we have cname adblocking, so we would look up the cname of devtool
When DoH is on, it usually has no problem but when the setting is automatic(default) or off, system resolver will not able to resolve the cname and hang there until timeout

@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2021

Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.22.67 Chromium: 89.0.4389.90 (Official Build) (64-bit)
--- | ---
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Linux
  • ensured that launching DevTools worked as expected via Hamburger Menu -> More tools --> Developer tools
  • ensured that CTRL + SHIFT + I launched the DevTools without any issues

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.22.67 Chromium: 89.0.4389.90 (Official Build) (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2009 (Build 19042.868)
  • ensured that launching DevTools worked as expected via Hamburger Menu -> More tools --> Developer tools
  • ensured that CTRL + SHIFT + I launched the DevTools without any issues
  • ensured that F12 launched the DevTools without any issues

@rebron
Copy link
Collaborator

rebron commented Mar 23, 2021

Looks good on macOS 11.2.2 using the following build:

Brave 1.22.67 Chromium: 89.0.4389.90 (Official Build) (arm64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.2 (Build 20D80)
  • Ensured right click Inspect on web page opens up dev tools
  • From hamburger menu -> Developer Tools opens and closes with no issue

Wasn't able to reproduce this issue on macOS 1.22.66 arm64 builds.

@shanytc
Copy link
Author

shanytc commented Mar 23, 2021

1.22.67

Issue still persists in this build.
Developer tools will not open on a fresh new install.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2021

1.22.67

Issue still persists in this build.
Developer tools will not open on a fresh new install.

@shanytc have you edited the DoH settings under brave://settings/security by any chance? Example:

image

We've checked every platform using 1.22.67 and it seems to be working. When you go into brave://version, are you seeing 1.22.67 or 1.22.66, Also, which platform are you using? Sounds like OSX? Can you let us know the exact version you're on?

@shanytc
Copy link
Author

shanytc commented Mar 23, 2021

1.22.67

Issue still persists in this build.
Developer tools will not open on a fresh new install.

@shanytc have you edited the DoH settings under brave://settings/security by any chance? Example:

image

We've checked every platform using 1.22.67 and it seems to be working. When you go into brave://version, are you seeing 1.22.67 or 1.22.66, Also, which platform are you using? Sounds like OSX? Can you let us know the exact version you're on?

Here is the version information I'm running:

Brave 1.22.67 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 10.15.7 (Build 19H524)
JavaScript V8 8.9.255.20

I have the same DoH settings under brave://settings/security as you posted in the image.

I tested with:

  1. Secure DNS off -> Doesn't open
  2. current service provider -> 1min-2min to open, , very slow and unusable.
  3. custom dns: Google, Cloudflare..etc -> will take 10-20secs to open, very slow and unusable.

@stephendonner
Copy link

Verified PASSED using

Brave 1.22.67 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Tested and verified:

  1. Right-click -> Inspect opens the Developer Tools promptly, and selects the chosen element
  2. Keybinding Option + Command + I opens (and toggles closed) the Developer Tools panel promptly
  3. Hamburger menu -> More Tools -> Developer Tools opens them promptly

@riequilibrium
Copy link

Hello,
I updated Brave to the latest version but the developer tools are still loading very slowly.
Having this issue for a while now.

macOS Catalina 10.15.7 (19H524)
Brave Version 1.22.67 Chromium: 89.0.4389.90 (Official build) (x86_64)

@shanytc
Copy link
Author

shanytc commented Mar 24, 2021

I have no idea who tested the fix, but clearly it hasn't been fixed.
Also, why would you want to do DNS check for opening a developer tools...?

@riequilibrium
Copy link

It seems that the built-in adblocker is intercepting the devtool call, disabling the Secure DNS or using another DNS like Cloudflare actually fixed the slowdown, but it is clearly a temporary workaround.

You can try it, go to Settings->Security, under Advanced you'll find the option for Secure DNS, select Cloudflare and now the devtools should open instantly!

image

Hopes this helps you!

@M-BenAli
Copy link

M-BenAli commented Mar 24, 2021

Relaunching brave fixed the slow developer tools startup for me, this option is ONLY be available if the update hasn't fully been completed yet. Go to: Settings -> About brave ->Relaunch brave option.

@shanytc
Copy link
Author

shanytc commented Mar 24, 2021

Relaunching brave fixed the slow developer tools startup for me, this option is ONLY be available if the update hasn't fully been completed yet. Go to: Settings -> About brave ->Relaunch brave option.

Doesn't fix the issue.

@jowsey
Copy link

jowsey commented Mar 24, 2021

It seems that the built-in adblocker is intercepting the devtool call, disabling the Secure DNS or using another DNS like Cloudflare actually fixed the slowdown, but it is clearly a temporary workaround.

Can confirm this works as a fix for now, using Cloudflare DNS

@shanytc
Copy link
Author

shanytc commented Mar 24, 2021

It seems that the built-in adblocker is intercepting the devtool call, disabling the Secure DNS or using another DNS like Cloudflare actually fixed the slowdown, but it is clearly a temporary workaround.

Can confirm this works as a fix for now, using Cloudflare DNS

It still takes around 10+ seconds for the developer tools to show up with CloudFlare DNS... this is a hack and not a solution.
Developer tools should not even use any dns remote check.

@dougfarnes
Copy link

This is not completely fixed for my install either.

@kjozwiak, my settings are as shown in your screenshot and dev tools take forever to open right now. However, if I apply the workaround by @riequilibrium (forcing Cloudflare DNS), dev tools open instantly. Also, if I connect to a self-hosted Wireguard VPN, dev tools load without delay.

Not sure what this means, if my local DNS setup is conflicting with what Brave is trying to do vis-a-vis CNAME adblocking, or how that relates to dev tools, but wanted to add another data point.

@bsclifton
Copy link
Member

bsclifton commented Mar 24, 2021

Thanks for the reports folks 😄 We do have a proper fix for this which I'd like to ask if you can try

This would be on Nightly - but you can download / install / test and then uninstall after testing. We just need to know it fixes for sites you visit. The version you can download is here:
https://github.com/brave/brave-browser/releases/tag/v1.24.18

Windows (64-bit) users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/BraveBrowserStandaloneNightlySetup.exe

macOS users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/Brave-Browser-Nightly-x64.dmg

cc: @dougfarnes @shanytc @jowsey @riequilibrium

For those interested, the fix can be found here:
brave/brave-core#8336

@shanytc
Copy link
Author

shanytc commented Mar 24, 2021

Thanks for the reports folks 😄 We do have a proper fix for this which I'd like to ask if you can try

This would be on Nightly - but you can download / install / test and then uninstall after testing. We just need to know it fixes for sites you visit. The version you can download is here:
https://github.com/brave/brave-browser/releases/tag/v1.24.18

Windows (64-bit) users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/BraveBrowserStandaloneNightlySetup.exe

macOS users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/Brave-Browser-Nightly-x64.dmg

cc: @dougfarnes @shanytc @jowsey @riequilibrium

For those interested, the fix can be found here:
brave/brave-core#8336

Nightly works perfectly!!!

@kjozwiak
Copy link
Member

kjozwiak commented Mar 24, 2021

Thanks @shanytc 👍 We'll get a hotfix out tomorrow with the above fix and push it to the release channel.

@shanytc
Copy link
Author

shanytc commented Mar 24, 2021

Thanks @shanytc 👍 We'll get a HF out tomorrow with the above fix on release.

Good work, thanks guys!

@riequilibrium
Copy link

Thanks for the reports folks 😄 We do have a proper fix for this which I'd like to ask if you can try

This would be on Nightly - but you can download / install / test and then uninstall after testing. We just need to know it fixes for sites you visit. The version you can download is here:
https://github.com/brave/brave-browser/releases/tag/v1.24.18

Windows (64-bit) users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/BraveBrowserStandaloneNightlySetup.exe

macOS users will want to download this one:
https://github.com/brave/brave-browser/releases/download/v1.24.18/Brave-Browser-Nightly-x64.dmg

cc: @dougfarnes @shanytc @jowsey @riequilibrium

For those interested, the fix can be found here:
brave/brave-core#8336

I can confirm that the Nightly version works like a charm!
Looking forward to install the hotfix on the stable release,
Thanks a lot!

@garyburgmann
Copy link

This has been driving me bonkers! But at least this issue has lead me to discover raindrop.io while I run Firefox :)

Can confirm that the Nightly version appears to also work for me running macOS Version 11.2.3 (Build 20D91)

@bsclifton
Copy link
Member

@garyburgmann if you update the Release channel version, it should now be fixed too 😄

@amuagarwal
Copy link

It look like that the issue is resurfaced with [Version 1.45.116 Chromium: 107.0.5304.91 (Official Build) (64-bit)]

@stephendonner
Copy link

It look like that the issue is resurfaced with [Version 1.45.116 Chromium: 107.0.5304.91 (Official Build) (64-bit)]

Please file a new issue with specific details (steps to reproduce, any performance timings, etc. - as much as you can). Thanks.

@amuagarwal
Copy link

It look like that the issue is resurfaced with [Version 1.45.116 Chromium: 107.0.5304.91 (Official Build) (64-bit)]

Please file a new issue with specific details (steps to reproduce, any performance timings, etc. - as much as you can). Thanks.

Already filled issue, but seems it fixed with [Version 1.45.118 Chromium: 107.0.5304.91 (Official Build) (64-bit)]
#6469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment