Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page Branded Logo is hidden when content has to scroll #13694

Closed
petemill opened this issue Jan 21, 2021 · 3 comments · Fixed by brave/brave-core#7614
Closed

New Tab Page Branded Logo is hidden when content has to scroll #13694

petemill opened this issue Jan 21, 2021 · 3 comments · Fixed by brave/brave-core#7614

Comments

@petemill
Copy link
Member

Description

When the New Tab Page has so many widgets that cause the window to scroll to see more content, the Branded Logo, which is fixed to the footer area, is also hidden by an overflow of content.

image

@petemill
Copy link
Member Author

Closed via #13694

@kjozwiak
Copy link
Member

Cases/Example of what needs to be verified can be found via brave/brave-core#7614 (comment).

@btlechowski
Copy link

btlechowski commented Jan 27, 2021

Verification passed on

Brave 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

image
image
image


Verified passed with

Brave	1.19.87 Chromium: 88.0.4324.96 (Official Build) (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified items from brave/brave-core#7614 (comment).
Confirmed that the sponsored NTP logo doesn't go below the fold when reducing the size of the browser window.
Confirmed that brave/brave-core#7614 (review) didn't occur when using Brave Today feature.

Example below, reproduced issue on 1.19.86. Updated to 1.19.87 and confirmed same window size now shows the logo as expected.

1.19.86 1.19.87
1 19 86 1 19 87

Verification passed on


Brave | 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

  • ensured that the sponsored NTP logo doesn't go below the fold when reducing the size of the browser window

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment