Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #10860 - Unable to create sync chain due to leading and trailing whitespace in code words #13681

Closed
GeetaSarvadnya opened this issue Jan 20, 2021 · 5 comments
Labels
bug feature/sync OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #10860 - Unable to create sync chain due to leading and trailing whitespace in code words

Steps to Reproduce

  1. Follow the steps from Unable to create sync chain due to leading and trailing whitespace in code words #10860 (comment)

Actual result:

Invalid Code Words error is shown

Expected result:

Leading and trailing whitespace in code words should be trimmed
Sync chain should be created

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc @brave/legacy_qa @jsecretan @rebron @darkdh @AlexeyBarabash @yrliou @petemill

@btlechowski
Copy link

btlechowski commented Jan 21, 2021

Not reproducible on Linux. Created sync between 1.20.86(dev) and 1.20.85(beta). Added spaces and enters to the code words.

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
Brave 1.20.85 Chromium: 88.0.4324.96 (Official Build) beta (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Linux

@AlexeyBarabash
Copy link
Contributor

cannot reproduce on my dev computer

Brave 1.22.8 Chromium: 89.0.4389.40 (Developer Build) (64-bit)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}

@AlexeyBarabash
Copy link
Contributor

Cannot reproduce on my Windows computer,
Nightly

Brave 1.22.6 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS Windows 10 OS Version 2004 (Build 19041.746)

Beta

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (64-bit)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS Windows 10 OS Version 2004 (Build 19041.746)

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 19, 2021
@jonathansampson
Copy link
Contributor

@GeetaSarvadnya Can this issue be closed, since the sync-codes are now being trimmed of leading and trailing whitespace before being counted?

@jsecretan
Copy link

Closing this because I believe it is fixed, but we can re-open if not the case

@jsecretan jsecretan added this to the 1.21.x - Release milestone Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/sync OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
Status: Completed
Development

No branches or pull requests

6 participants