Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create sync chain due to leading and trailing whitespace in code words #10860

Closed
btlechowski opened this issue Jul 22, 2020 · 2 comments · Fixed by brave/brave-core#7239

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Clean install DeviceA and DeviceB
  2. On DeviceA open brave://settings/braveSync/setup
  3. On DeviceA click Start a new sync chain
  4. On DeviceA click Computer
  5. On DeviceA copy the code words
  6. Add leading and trailing white space to the code words
  7. On DeviceB use the code words
  8. Wait for the sync chain creation

Actual result:

Invalid Code Words error is shown

Expected result:

Leading and trailing whitespace in code words are trimmed
Sync chain is created

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
Brave 1.13.36 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @jsecretan @rebron @darkdh @AlexeyBarabash @yrliou @petemill

@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 25, 2020
@AlexeyBarabash
Copy link
Contributor

I can reproduce.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 20, 2021

Verification passed on


Brave | 1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)


Verification passed on

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS
Brave 1.20.85 Chromium: 88.0.4324.96 (Official Build) beta (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Linux

Verified test plan from the description. Created sync between 1.20.86(dev) and 1.20.85(beta). Added spaces and enters to the code words.

Verified test plan from the description; DeviceA was my Windows 10 Dev build, with DeviceB being this macOS build, below. Added leading space and trailing space characters, then chained and successfully synced between devices.

Brave 1.20.90 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)

@rebron rebron changed the title [Desktop] Unable to create sync chain due to leading and trailing whitespace in code words Unable to create sync chain due to leading and trailing whitespace in code words Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants