Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full page explainer for unconfigured ipfs:// loads instead of loading content with an infobar #13655

Closed
bbondy opened this issue Jan 19, 2021 · 9 comments · Fixed by brave/brave-core#7918

Comments

@bbondy
Copy link
Member

bbondy commented Jan 19, 2021

Description

For new IPFS users that load ipfs:// or ipns:// URLs, show a webui page that gives an explainer instead of loading content through a gateway with an infobar.

The infobar is pretty packed, and we'd rather not use the gateway by default without user consent.

We currently load the content + have this infobar:
Screen Shot 2021-01-19 at 9 53 36 AM

Instead we should show a full page webui explainer page. If the user goes in settings and selects Ask we'd just show this page again.

Designs

image

When the user clicks "Use local node", show a loading spinner to indicate the node is being installed before redirecting to the requested content:
image

image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=94%3A7772

@bbondy bbondy changed the title Use full page explainer instead of loading content with an infobar Use full page explainer for ipfs:// loads instead of loading content with an infobar Jan 19, 2021
@bbondy bbondy changed the title Use full page explainer for ipfs:// loads instead of loading content with an infobar Use full page explainer for unconfigured ipfs:// loads instead of loading content with an infobar Jan 19, 2021
@PrivacyMatters
Copy link

That's very helpful

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 19, 2021
@jessicaschilling
Copy link

Commenting to follow this issue - and would be happy to help with language etc when you start working on this one, particularly so we can be sure to remain consistent with other IPFS tools like Companion. Thanks! 🙏

@lidel
Copy link

lidel commented Jan 20, 2021

Yes! Quick thought:

We should account for tyranny of small decisions and if we want true decentralization, we should promote running local nodes.
Perhaps we reorder options so that the local node is the first one + the option has slight tint/color accent to indicate "pick this for best outcome"?

@karenkliu
Copy link

Designs added!

@bbondy
Copy link
Member Author

bbondy commented Jan 20, 2021

Awesome work, thank you @karenkliu!

@jessicaschilling
Copy link

jessicaschilling commented Jan 20, 2021

This is awesome! Would love to request a few text changes just for consistency with IPFS-land in general?

  • In the explanatory graf, InterPlanetary File System (IPFS) is the public network -> IPFS (InterPlanetary File System) is the public network
  • First option text: and content you're requesting -> and any content you're requesting
  • First option text: Content is verified -> Content you request over IPFS is verified
  • First option text: before being served. -> before being served to you.
  • Second option text: from everyone else -> from potential third-party observers
  • Second option text: The operator is responsible for serving you the correct requested content. -> The gateway operator is responsible for ensuring that the content served to you over a gateway is the content you requested.
  • Second option text: to the public network -> to the public IPFS network

@jessicaschilling
Copy link

Also - @autonome, would appreciate your eyes on this as well. Thanks!

@ryanml
Copy link
Contributor

ryanml commented Feb 8, 2021

Front end work will pushed to this branch: https://github.com/brave/brave-core/tree/feature-13655 cc: @spylogsster

@stephendonner
Copy link

stephendonner commented Feb 22, 2021

Verified FIXED using nightly on macOS Big Sur (11.2.1) with:

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

ipfs-install-new
Screen Shot 2021-02-22 at 2 50 16 PM

Verified that the links go to the correct URLs, that brave://settings/ipfs options are present and work, and that the text from #13655 (comment) was updated and reflected in the UI.

The spinner on the "Installing..." orange button isn't present; will file a new bug for that and cross-reference it here.


Verification passed on


Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Enable IPFS

image
image
image


Verification passed on

Brave 1.22.58 Chromium: 89.0.4389.86 (Official Build) beta (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment