-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full page explainer for unconfigured ipfs:// loads instead of loading content with an infobar #13655
Comments
That's very helpful |
Commenting to follow this issue - and would be happy to help with language etc when you start working on this one, particularly so we can be sure to remain consistent with other IPFS tools like Companion. Thanks! 🙏 |
Yes! Quick thought: We should account for tyranny of small decisions and if we want true decentralization, we should promote running local nodes. |
Designs added! |
Awesome work, thank you @karenkliu! |
This is awesome! Would love to request a few text changes just for consistency with IPFS-land in general?
|
Also - @autonome, would appreciate your eyes on this as well. Thanks! |
Front end work will pushed to this branch: https://github.com/brave/brave-core/tree/feature-13655 cc: @spylogsster |
Verified
Verified that the links go to the correct URLs, that The spinner on the "Installing..." orange button isn't present; will file a new bug for that and cross-reference it here. Verification passed on
Verification passed on
Verified test plan from the description |
Description
For new IPFS users that load ipfs:// or ipns:// URLs, show a webui page that gives an explainer instead of loading content through a gateway with an infobar.
The infobar is pretty packed, and we'd rather not use the gateway by default without user consent.
We currently load the content + have this infobar:
Instead we should show a full page webui explainer page. If the user goes in settings and selects
Ask
we'd just show this page again.Designs
When the user clicks "Use local node", show a loading spinner to indicate the node is being installed before redirecting to the requested content:
Assets
Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=94%3A7772
The text was updated successfully, but these errors were encountered: