-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cosmetic filters #13070
Comments
@SergeyZhukovsky is there a test plan for this other than the STR? |
@pes10k @antonok-edm do we have any test plan for that from the original implementation? |
@antonok-edm will know more automated tests than me, but I have been snowballing manual / QA tests here: https://dev-pages.brave.software/cosmetic-filtering/text-ads.html Happy to add more if it'd be helpful |
@SergeyZhukovsky The original implementation was tracked at #5381. There was a test plan there, although as far as I can see, the website in question has since been updated so that it no longer has the ad spot. @LaurenWags the STR here is a pretty good test case though 😄 |
perfect, thanks all! just wanted to make sure QA tested this appropriately 😄 |
Verified passed with
Verified STR from description. Confirmed no empty space at the top: Confirmed "Trackers & ads blocked" setting values on https://dev-pages.brave.software/cosmetic-filtering/text-ads.html:
Verification passed on
Verified STR from description. Confirmed no empty space at the top: Verified "Trackers & ads blocked" setting values on https://dev-pages.brave.software/cosmetic-filtering/text-ads.html:
Verified passed with
Verified STR from description. Confirmed no empty space at the top: Confirmed "Trackers & ads blocked" setting values on https://dev-pages.brave.software/cosmetic-filtering/text-ads.html:
|
Verification passed on OnePlus 6T with Android 10 running 1.21.70 x64 build
Verification passed on OnePlus 6T with Android 10 running 1.21.70 x64 build
|
Description
We need a common solution for Android and desktop for that feature. The goal is to make it happen without using extensions.
Steps to Reproduce
Actual result:
Expected result:
No empty space
Reproduces how often:
Desktop Brave version:
Android Device details:
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: