Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learn more (on about page) should go to a more helpful support page #11746

Closed
bsclifton opened this issue Sep 16, 2020 · 2 comments · Fixed by brave/brave-core#6659
Closed

Learn more (on about page) should go to a more helpful support page #11746

bsclifton opened this issue Sep 16, 2020 · 2 comments · Fixed by brave/brave-core#6659
Assignees
@bsclifton
Labels
documentation ✍️ OS/Desktop OS/Windows QA Pass-Win64 QA/Test-Plan-Required QA/Yes release-notes/include
Milestone
1.16.x - Release #1

Comments

@bsclifton
Copy link
Member

Description

Learn more link should go to a more helpful support page for Windows users
image

Steps to Reproduce

  1. Go to brave://settings/help
  2. Experience an error updating (??)
  3. Click the Learn more link

Actual result:

It goes to https://community.brave.com?p=update_error

Expected result:

It should go to https://support.brave.com/hc/en-us/articles/360042816611-Why-isn-t-Brave-updating-automatically-on-Windows-
@bsclifton bsclifton self-assigned this Sep 16, 2020
@bsclifton bsclifton mentioned this issue Sep 16, 2020
Merged
32 tasks
@bsclifton
Copy link
Member Author

I'll try to find a proper way to test this on Windows and macOS/Linux

bsclifton added a commit to brave/brave-core that referenced this issue Sep 17, 2020
@bsclifton
Update help link to be relevant for Windows users
b1380ee 
The <if> expression will get evaluated properly by grit

Fixes brave/brave-browser#11746
@bsclifton bsclifton added this to the 1.16.x - Nightly milestone Sep 17, 2020
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
@bsclifton @deeppandya
Update help link to be relevant for Windows users
8dd4e1e 
The <if> expression will get evaluated properly by grit

Fixes brave/brave-browser#11746
@btlechowski
Copy link

Verification passed on

Brave 1.16.54 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified by closing the browser during update and immediately relaunching it.
Verified Dowiedz się więcej (Learn more) is shown

image

Verified Learn more points to https://support.brave.com/hc/en-us/articles/360042816611-Why-isn-t-Brave-updating-automatically-on-Windows-
image

@LaurenWags LaurenWags mentioned this issue Oct 26, 2020
Closed
@rebron rebron changed the title [Desktop] Learn more (on about page) should go to a more helpful support page Learn more (on about page) should go to a more helpful support page Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
documentation ✍️ OS/Desktop OS/Windows QA Pass-Win64 QA/Test-Plan-Required QA/Yes release-notes/include
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Update help link to be relevant for Windows users brave/brave-core
3 participants
@bsclifton @btlechowski and others