Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Gemini widget with translated text overlap making it hard to read #10742

Closed
srirambv opened this issue Jul 15, 2020 · 3 comments · Fixed by brave/brave-core#6119
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 15, 2020

Description

Gemini widget with translated text overlap making it hard to read

Steps to Reproduce

  1. Set locale to German
  2. Start a new profile and open a new tab
  3. Connect Gemini widget to your account
  4. Text overlap on each other making it hard to read

Actual result:

image

Expected result:

The translated text should be legible to read

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.14 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@ryanml
Copy link
Contributor

ryanml commented Jul 17, 2020

@srirambv do you think you can split this issue? (One for Binance, one for Gemini) We are going to do an icon nav approach for Binance, and for Gemini we will make more efficient use of spacing.

@srirambv
Copy link
Contributor Author

Logged #10788 for Icon replacement

@srirambv srirambv changed the title [Desktop] Widget translations overlap on each other making it hard to read [Desktop] Gemini widget with translated text overlap making it hard to read Jul 17, 2020
@ryanml ryanml added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 17, 2020
@ryanml ryanml self-assigned this Jul 17, 2020
ryanml added a commit to brave/brave-core that referenced this issue Jul 19, 2020
@ryanml ryanml added this to the 1.13.x - Nightly milestone Jul 23, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
  • Verified widget is translated and text isn't overlapping
    image

Verification passed on

Brave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Windows 10 OS Version 1809 (Build 17763.1397)
  • Verified widget is translated and text isn't overlapping
    image

Verification passed on

Brave 1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS macOS Version 10.15.5 (Build 19F101)
  • Verified widget is translated and text isn't overlapping
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants