Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening Brave on a Mac by following a link from another app, URL does not appear in frontmost window #1040

Open
davidtemkin opened this issue Sep 8, 2018 · 4 comments
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. repros-on-chrome

Comments

@davidtemkin
Copy link

Description

When opening Brave on a Mac by clicking on a link from a different app (e.g., Mail, Slack), and Brave is not already running, Brave opens as expected, but the page corresponding to the link does not appear in the frontmost window.

Steps to Reproduce

  1. Make sure Brave is the default browser
  2. Open a bunch of windows/tabs
  3. Quit Brave
  4. Follow a link in another Mac app
  5. Brave opens

Actual result:

The desired link/tab is opened but not in the front window.

Expected result:

The desired link/tab is opened and is frontmost (window is frontmost)

Reproduces how often:

Easily reproduced but may work sometimes

Brave version (about:brave info)

Version 0.55.2 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)

Reproducible on current release:

Actually, yes.

Found on Mac; may or may not occur on other platforms.

@bbondy bbondy added this to the 1.x Backlog milestone Sep 9, 2018
@rebron rebron added the needs-investigation A bug not 100% confirmed/fixed label Feb 5, 2019
@rebron
Copy link
Collaborator

rebron commented Feb 5, 2019

Need to investigate. Can't reproduce.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-investigation A bug not 100% confirmed/fixed labels Feb 12, 2019
@rebron rebron self-assigned this Feb 12, 2019
@rebron
Copy link
Collaborator

rebron commented Feb 12, 2019

cc: @kjozwiak to reproduce but it deals with restore tab/focus.

@kjozwiak
Copy link
Member

Managed to reproduce this pretty easily on macOS 10.14.2 x64. Happens 100% of the time using the following STR:

  • load brave.com and basicattentiontoken.org on Window A
  • load linkedin.com and duckduckgo.como on Window B
  • ensure that Brave is the default browser
  • close Brave
  • click on a link in another application like Slack

What happens in the above situation is that the opened link opens in Window C but Windows B is frontmost with the active tab being the one before clicking on the external link. If you have a lot of windows opened, it's a pain to find the link that was just opened.

Reproduced with the following builds:

Brave 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X
Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

@rebron rebron removed their assignment Feb 14, 2019
@kjozwiak
Copy link
Member

Also reproducible on Chrome: 75.0.3770.80 (Official Build) (64-bit) using the STR from both #1040 (comment) and #1040 (comment).

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P3 Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. repros-on-chrome
Projects
Status: P3 Backlog
Development

No branches or pull requests

4 participants